f/accelerator-admin-support merge to incubation
#2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue-1417 Show non-DS projects in the project table
dry run and show error message on storage modal
…ue-1480 Support storage size unit and show error message correctly
…rd into f/ds-projects
Add Accelerator section in Admin Panel and feature flag
…ue-2031 Add tests for project view
…t-feature-check Support Areas over just feature flags
Fix page title sentence casing
Adapt logic for Custom Serving Runtime migration and adapt OVMS OOTB
Add tooltips to Model Server Modal
…ue-2049 Automatically generate first token when enable route when adding modelmesh server
Merge `main` into `f/model-serving` and solve conflicts
logic for deprecated images added tests fix annotations made annotations land labels optional supported disabled wording unknown state will not use a label Updated tests, updated UI fix tests small fixes added deleted disabled loaded always signifies data exists moved popover
…-store logic for deprecated images
updated tests
…ue-2047 Add info alert to kserve on settings page
…ue-2134 Show error state on global serving page when the platform in not installed
…rving Merge `f/model-serving` to `main`
clean up separated components fixed js key error fix tests tooltips to popover and direction of popup wording fixes fixes removed popover for toleration table fixed error handling fix small fixes aria fix
Added accelerator edit page
added PF bug comment
fix truncating spacing issue
Add accelerator table
…arators improve section divider rendering
…ue-2120 Remove projects filter on the project view page
added tests tooltip to popover naming fix, and new ux added new disbaled state make label compact added navigate to create rerender fix add comment remove span changed icons added loading
Added accelerator column and field
update `f/accelerator-admin-support` with main
Accelerator profile table filter
updated text fix test fix fix merge
add delete accelerator profile modal
…nto accelerator-admin-incubation
|
Is this a problem? |
|
ran through manually testing of the feature with an image in the cluster. all good. adding labels |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 44496c1
into
opendatahub-io:incubation
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set #1255 to incubating
Description
alright... all tests pass but model serving seemed to have the most trouble getting to pass. I am using the tests from main not incubation bc incubation was missing structure.
the other big conflicts had to do with performance metrics, service mesh, and bias metrics. those i had to swithc over to using the new feature flag area stuff. this was not big, just had to replace where usefeatureflag was used
other than that, it was mostly ok and merge combined the rest of the conflicts
How Has This Been Tested?
go over core ares and make sure they still work
Test Impact
all tests pass
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main