Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non-DS projects in the project table #1643

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Aug 7, 2023

Closes #1417
Closes #1310

Description

Add a select field, allowing the user to select the scope of the project table.
When selecting Data science projects:

Screenshot 2023-08-07 at 3 50 00 PM

When selecting All available projects:

Screenshot 2023-08-07 at 3 53 45 PM

Also, only apply the modelmesh-enabled: 'true' annotation when first creating a server in a project.

How Has This Been Tested?

  1. Go to the dashboard projects page
  2. Toggle the select dropdown to view different scopes
  3. Make sure projects starts with openshift- or kube- or default or system or openshift or the dashboard namespace are not shown in the list
  4. Try to create a workbench in a non-DS project

Test Impact

TBD

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode
Copy link
Member Author

I have some questions about RBAC for this PR that needs more information or answers.

  1. Does the scope limit access to the specific project? For example, if an admin user has access to some non-DS projects, and he sets the scope to Data science projects, now he can only see DS projects in the list. However, can he access the project details page of a non-DS project by typing in the URL? Currently, in this implementation he can, because we only limit the scope filter from a UI perspective, but we didn't set any RBAC limitation.
  2. Does the scope affects other pages like Data science pipelines? For example, on the DS pipelines page, you will need to select a project to create a pipeline. If the user limits the scope to DS projects only, can he still see the non-DS projects in this list? Currently, we don't do any filters here. Do we want to only show DS projects here no matter what scope the user chooses on the projects page or do we want to show the projects based on the user's choice of scope?
Screenshot 2023-08-07 at 4 41 09 PM

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Code looks great and the PR is mostly doing what the description of the issue is asking.
I have some concerns, such as displaying the dashboard namespace and the fact that I'm not sure if the issue itself was asking to have the ability to convert a non ds project into one (this pr doesn't have that logic but I don't see that flow in the requirements nor the mocks).

I can stamp an approval but I would love to have further conversations about this.

@manaswinidas manaswinidas self-assigned this Aug 8, 2023
@lucferbux lucferbux added the do-not-merge/hold This PR is hold for some reason label Aug 9, 2023
@lucferbux
Copy link
Contributor

/hold

This issue will slip to next sprint, we've changed the priorities and we'll only merge bug fixes.

@kywalker-rh
Copy link

@xianli123 - This is to implement your design so please take a look when you get a chamce.

@xianli123
Copy link

@kywalker-rh Thanks. The UI looks good to me. As for the divider, it can be removed, as decided in this Slack thread.

@openshift-ci openshift-ci bot removed the lgtm label Aug 15, 2023
@DaoDaoNoCode
Copy link
Member Author

Based on the discussion we had in the UX meeting, we are not going to block/filter any OpenShift projects, we will fetch whatever we get and show them to the users. Most of the users are developers only, and RBAC will prevent them from seeing the OpenShift default projects. As for admin users, they should know what they are doing so there is no harm to show all the projects to them :)

@andrewballantyne
Copy link
Member

/hold

Yeah, holding this until we can discuss the "showing of infrastructure projects" in the Dashboard. I disagree with the stance made in the UX meeting last week.

@DaoDaoNoCode
Copy link
Member Author

/unhold Already hid all the infrastructure projects.

@DaoDaoNoCode DaoDaoNoCode removed the do-not-merge/hold This PR is hold for some reason label Aug 24, 2023
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 24, 2023
@DaoDaoNoCode DaoDaoNoCode changed the base branch from main to f/ds-projects August 24, 2023 19:47
@christianvogt
Copy link
Contributor

/lgtm
/approve

@DaoDaoNoCode
Copy link
Member Author

@christianvogt I am wondering whether this could go through the merge process because I changed the target branch halfway 🤔

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: christianvogt, Gkrumbach07, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DaoDaoNoCode
Copy link
Member Author

Manually add approved label to see if the merge could happen.

@openshift-merge-robot openshift-merge-robot merged commit 2b620ba into opendatahub-io:f/ds-projects Aug 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create data science project in existing namespace [Bug]: Delay Model Serving Annotation until First Server
9 participants