-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show non-DS projects in the project table #1643
Show non-DS projects in the project table #1643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Code looks great and the PR is mostly doing what the description of the issue is asking.
I have some concerns, such as displaying the dashboard namespace and the fact that I'm not sure if the issue itself was asking to have the ability to convert a non ds project into one (this pr doesn't have that logic but I don't see that flow in the requirements nor the mocks).
I can stamp an approval but I would love to have further conversations about this.
/hold This issue will slip to next sprint, we've changed the priorities and we'll only merge bug fixes. |
@xianli123 - This is to implement your design so please take a look when you get a chamce. |
@kywalker-rh Thanks. The UI looks good to me. As for the divider, it can be removed, as decided in this Slack thread. |
Based on the discussion we had in the UX meeting, we are not going to block/filter any OpenShift projects, we will fetch whatever we get and show them to the users. Most of the users are developers only, and RBAC will prevent them from seeing the OpenShift default projects. As for admin users, they should know what they are doing so there is no harm to show all the projects to them :) |
frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx
Outdated
Show resolved
Hide resolved
/hold Yeah, holding this until we can discuss the "showing of infrastructure projects" in the Dashboard. I disagree with the stance made in the UX meeting last week. |
09f6f4d
to
b3caefa
Compare
/unhold Already hid all the infrastructure projects. |
b3caefa
to
9ee0ffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@christianvogt I am wondering whether this could go through the merge process because I changed the target branch halfway 🤔 |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: christianvogt, Gkrumbach07, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manually add |
2b620ba
into
opendatahub-io:f/ds-projects
Closes #1417
Closes #1310
Description
Add a select field, allowing the user to select the scope of the project table.
When selecting Data science projects:
When selecting All available projects:
Also, only apply the
modelmesh-enabled: 'true'
annotation when first creating a server in a project.How Has This Been Tested?
openshift-
orkube-
ordefault
orsystem
oropenshift
or the dashboard namespace are not shown in the listTest Impact
TBD
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main