Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Delay Model Serving Annotation until First Server #1310

Closed
1 task done
andrewballantyne opened this issue May 30, 2023 · 1 comment · Fixed by #1643
Closed
1 task done

[Bug]: Delay Model Serving Annotation until First Server #1310

andrewballantyne opened this issue May 30, 2023 · 1 comment · Fixed by #1643
Assignees
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/bug Something isn't working priority/normal An issue with the product; fix when possible

Comments

@andrewballantyne
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Today, we create every namespace with the expectation of Model Serving.

We should delay the adding of the modelmesh-enabled label until we reach the point of Model Server creation.

This can create scale issues, as this NetworkPolicy relies on this label to define network flow rules:

apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  labels: ...
  name: etcd
  namespace: redhat-ods-applications
spec:
  ingress:
  - from:
    - namespaceSelector:
        matchLabels:
          modelmesh-enabled: "true"
    ports:
    - port: 2379
      protocol: TCP
  podSelector:
    matchLabels:
      app: model-mesh
      app.kubernetes.io/part-of: model-mesh
      component: model-mesh-etcd
  policyTypes:
  - Ingress

Expected Behavior

Delay labelling of project until we need it.

Steps To Reproduce

  1. Create Project
  2. View Labels on Project

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Open Data Hub Version

Dashboard: v2.7.0

Anything else

No response

@andrewballantyne andrewballantyne added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet labels May 30, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning May 30, 2023
@andrewballantyne andrewballantyne added feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature labels May 30, 2023
@lucferbux
Copy link
Contributor

To add more context, we are adding that label in case it's missing when creating a new model server, the outcome here would be removing the label creation when creating a project.

@Gkrumbach07 Gkrumbach07 added priority/normal An issue with the product; fix when possible and removed untriaged Indicates the newly create issue has not been triaged yet labels May 31, 2023
@Gkrumbach07 Gkrumbach07 moved this from Needs prioritization to To do in ODH Dashboard Planning May 31, 2023
@Gkrumbach07 Gkrumbach07 added this to the Upcoming Release milestone May 31, 2023
@andrewballantyne andrewballantyne removed this from the Current Release milestone Jul 6, 2023
@lucferbux lucferbux added the field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality label Jul 19, 2023
@DaoDaoNoCode DaoDaoNoCode self-assigned this Aug 8, 2023
@DaoDaoNoCode DaoDaoNoCode moved this from To do to In progress in ODH Dashboard Planning Aug 8, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in ODH Dashboard Planning Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-projects Data Science Projects feature (formerly Data Science Groupings - DSG) feature/model-serving Model Serving Feature field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/bug Something isn't working priority/normal An issue with the product; fix when possible
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants