Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltips to Model Server Modal #2003

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Add tooltips to Model Server Modal #2003

merged 1 commit into from
Nov 8, 2023

Conversation

uidoyen
Copy link
Contributor

@uidoyen uidoyen commented Oct 23, 2023 •
edited
Loading

Closes: #1580

Description

Add tooltips to Model Server Modal

Screenshot 2023-10-23 at 2 47 39 PM

How Has This Been Tested?

  • Create DS Project
  • Scroll down to Models and model servers section
  • Click Add model server button
  • under Add model server pop up check to verify the popover

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux lucferbux linked an issue Oct 26, 2023 that may be closed by this pull request
Add popovers to Model Server Modal #1580
Closed
@lucferbux
Copy link
Contributor

@uidoyen can you squah the commits please?

lucferbux
lucferbux requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, we need testing, mostly integration for this part.

...nd/src/pages/modelServing/screens/projects/ServingRuntimeModal/ServingRuntimeSizeSection.tsx Outdated Show resolved Hide resolved
@lucferbux
Copy link
Contributor

@uidoyen we'll carry over this to next sprint, can you add the testsuite please?

christianvogt
christianvogt reviewed Nov 1, 2023
View reviewed changes
...src/pages/modelServing/screens/projects/ServingRuntimeModal/ServingRuntimeReplicaSection.tsx Outdated
Comment on lines 31 to 35
<Popover bodyContent={<div>{infoContent}</div>}>
<HelpIcon aria-label="More info" />
</Popover>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a mix of HelpIcon and QuestionCircleIcon in various parts of the UI. @vconzola which is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uidoyen please change all instances of HelpIcon to QuestionCircleIcon

@vconzola
Copy link

vconzola commented Nov 2, 2023

@christianvogt I don't even know what HelpIcon looks like. If it's to indicate in context help (popovers, mostly I assume), then it should be fa-question-circle (outlined).

@uidoyen
Copy link
Contributor Author

uidoyen commented Nov 2, 2023

@christianvogt I don't even know what HelpIcon looks like. If it's to indicate in context help (popovers, mostly I assume), then it should be fa-question-circle (outlined).

@vconzola this is how the HelpIcon looks.

Screenshot 2023-11-02 at 3 23 51 PM

@vconzola
Copy link

vconzola commented Nov 2, 2023

@christianvogt Interesting. I don't see that icon in the PF icon library, so I don't know where it came from. It looks very similar to the fa-question-circle icon, except possibly darker. Regardless, according to PF guidelines, we should be using fa-question-circle for in context help (popovers, tooltips, etc.).

@lucferbux
Copy link
Contributor

As a follow up, we should do the same to kserve modal, I'm gonna approve and merge this but log another issue.

lucferbux
lucferbux approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 435bc9e into opendatahub-io:f/model-serving Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucferbux lucferbux lucferbux approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@ppadti ppadti Awaiting requested review from ppadti

@manaswinidas manaswinidas Awaiting requested review from manaswinidas

@kaedward kaedward Awaiting requested review from kaedward

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@lucferbux lucferbux

@manaswinidas manaswinidas

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add popovers to Model Server Modal
6 participants
@uidoyen @lucferbux @vconzola @christianvogt @manaswinidas @kaedward