Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accelerator table #2069

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Nov 6, 2023

Closes: #1373

Description

Added Accelerator profile table

  • Render the following columns: Device identifier, display name/description, ennoblement switch, date last modified, action button
  • Columns (except for action column) must be sortable
  • include help icons where present in the docs
  • should include pagination
  • ellipsis action button should include: edit, delete
  • hook to fetch accelerator CRDs

image

How Has This Been Tested?

  1. Add accelerator profile CR's to your cluster.
  2. Login to ODH dashboard with clusteradmin
  3. Navigate to settings < Accelerator profiles
  4. You can see the Accelerator table, with all it's fields, sortable columns, and action buttons.

Test Impact

Added storybook component and integration test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@yannnz

@dgutride dgutride linked an issue Nov 6, 2023 that may be closed by this pull request
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Nov 15, 2023

@dpanshug I think the test is failing. it could be an aria issue. there is a code suggestion with a fix

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2023
@Gkrumbach07
Copy link
Member

checked over once more. all looks good

Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8c9e2ec into opendatahub-io:f/accelerator-admin-support Nov 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add accelerator table
3 participants