-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accelerator table #2069
Add accelerator table #2069
Conversation
976d5a5
to
cd40cb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a empty file
frontend/src/pages/acceleratorProfiles/components/SearchField.tsx
frontend/src/__tests__/integration/pages/acceleratorProfiles/AcceleratorProfiles.spec.ts
Show resolved
Hide resolved
frontend/src/__tests__/integration/pages/acceleratorProfiles/AcceleratorProfiles.stories.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/components/AcceleratorProfileEnableToggle.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/components/TableData.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/components/TableData.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/components/TableData.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/components/TableData.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTable.tsx
Outdated
Show resolved
Hide resolved
f24c52a
to
66f008b
Compare
frontend/src/__tests__/integration/pages/acceleratorProfiles/AcceleratorProfiles.stories.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfileEnableToggle.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfileEnableToggle.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfileEnableToggle.tsx
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTableRow.tsx
Outdated
Show resolved
Hide resolved
66f008b
to
a1053d7
Compare
@dpanshug I think the test is failing. it could be an aria issue. there is a code suggestion with a fix |
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTableRow.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few comments
frontend/src/__tests__/integration/pages/acceleratorProfiles/AcceleratorProfiles.stories.tsx
Outdated
Show resolved
Hide resolved
a1053d7
to
0f7ae94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
checked over once more. all looks good |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8c9e2ec
into
opendatahub-io:f/accelerator-admin-support
Closes: #1373
Description
Added Accelerator profile table
How Has This Been Tested?
Test Impact
Added storybook component and integration test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@yannnz