Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2127
Description
From investigation. this problem is stemming from truncate adding on a min width of
12ch
which for small placeholders like None will cause a gap.Truncate should not have to be used because the dropdown text should truncate by default. The issue is that when this dropdown is in a
Form
(thats a PF form component) a grid styling is applied. For some reason the grid styling messes with the width and anything under a grid doesn't obey the bounds of the grid. Switching to (a) not using PF's Form or (b) setting the forms display to block will fix the overflow issue.I boiled it down to the very basics and still have no luck fixing it at the root. This seems like a PF bug at its core becuase i can reproduce it in a very basic test bed like this
How Has This Been Tested?
open add model modal and look at select serving runtime dropdown (or anywhere that uses this dropdown select component)
Test Impact
no tests needed, a visual bug fig
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
not needed bc this is for fixing an improper ux
After the PR is posted & before it merges:
main