-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add delete accelerator profile modal #2156
add delete accelerator profile modal #2156
Conversation
@yannnz not much unseen UX here though |
@Gkrumbach07 Sorry I think the delete modal is missed in the latest update mockup. Here is the content based on Andrew's and Katie's suggestions: https://sketch.com/s/d8550d2f-fae4-44fd-82df-9f400563d459/a/3oxP1aD?annotation=3c3bd330-470c-48ca-bec3-4a210b68a41b |
@yannnz based on that. this is what i came up with The deleteName accelerator profile will be deleted and will be unavailable for any i changed it becouse it does not remove the settings from existing resources, it switches into that "use existing settings" option |
955c6fd
to
701bbc4
Compare
frontend/src/pages/acceleratorProfiles/screens/list/AcceleratorProfilesTable.tsx
Show resolved
Hide resolved
updated text fix test fix fix merge
701bbc4
to
868812b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
going to merge this. if there is anything that needs changing we can try to get it in before it merges into incubation on friday. otherwise we can log a separate issue |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dpanshug The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8e09eb7
into
opendatahub-io:f/accelerator-admin-support
closes: #1376
Description
Adds a delete modal to accelerator profiles page and updated some internal text to say acceleratorProfile instead of accelerator
How Has This Been Tested?
Test Impact
added tests for delete flow
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main