Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete accelerator profile modal #2156

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Nov 15, 2023

closes: #1376

Description

Adds a delete modal to accelerator profiles page and updated some internal text to say acceleratorProfile instead of accelerator

image

How Has This Been Tested?

  1. create a profile
  2. located it on the table
  3. action button > delete
  4. delete should work and refresh the page automatically

Test Impact

added tests for delete flow

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07
Copy link
Member Author

Gkrumbach07 commented Nov 15, 2023

@yannnz not much unseen UX here though

@Gkrumbach07 Gkrumbach07 linked an issue Nov 15, 2023 that may be closed by this pull request
@yannnz
Copy link

yannnz commented Nov 16, 2023

@Gkrumbach07 Sorry I think the delete modal is missed in the latest update mockup. Here is the content based on Andrew's and Katie's suggestions: https://sketch.com/s/d8550d2f-fae4-44fd-82df-9f400563d459/a/3oxP1aD?annotation=3c3bd330-470c-48ca-bec3-4a210b68a41b
https://sketch.com/s/d8550d2f-fae4-44fd-82df-9f400563d459/a/3oxP1aD?annotation=33f860ce-c3e2-4c2d-bcff-d4f9d9dc8a07
Screenshot 2023-11-16 at 21 52 33

@Gkrumbach07
Copy link
Member Author

@yannnz based on that. this is what i came up with

The deleteName accelerator profile will be deleted and will be unavailable for any
workbenches and runtimes. Existing resources will retain their settings but cannot revert to
this profile once changed.

i changed it becouse it does not remove the settings from existing resources, it switches into that "use existing settings" option

@Gkrumbach07 Gkrumbach07 force-pushed the delete-modal branch 3 times, most recently from 955c6fd to 701bbc4 Compare November 16, 2023 15:57
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 16, 2023
updated text

fix test

fix

fix merge
Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
@Gkrumbach07
Copy link
Member Author

going to merge this. if there is anything that needs changing we can try to get it in before it merges into incubation on friday. otherwise we can log a separate issue

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dpanshug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8e09eb7 into opendatahub-io:f/accelerator-admin-support Nov 16, 2023
4 checks passed
@Gkrumbach07 Gkrumbach07 deleted the delete-modal branch January 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accelerator delete modal
4 participants