Automatically generate first token when enable route when adding modelmesh server #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucferbux
approved these changes
Nov 8, 2023
| @@ -138,6 +139,20 @@ const ManageServingRuntimeModal: React.FC<ManageServingRuntimeModalProps> = ({ | |||
| }); | |||
| }; | |||
|
|
|||
| const createNewToken = React.useCallback(() => { | |||
There was a problem hiding this comment.
Yeah, great idea moving the addition logic from the component, it will be more reusable.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 088120d
into
opendatahub-io:f/model-serving
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2049
Description
In #1862, we automatically check the
token authorizationcheckbox when the route is enabled. However, we didn't add the default service account in this action. This PR is to fix that issue.How Has This Been Tested?
Test Impact
Add a check in the integration test to make sure the service account token is added
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main