-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AnalysisLevel=latest-All and fix resulting issues #950
Comments
This was referenced Feb 3, 2023
Closed
cijothomas
added a commit
that referenced
this issue
Feb 6, 2023
Fix/suppress code analysis warnings in OpenTelemetry.Contrib.Exporter.Geneva. Contributes to #950. Co-authored-by: Cijo Thomas <[email protected]>
cijothomas
added a commit
that referenced
this issue
Feb 6, 2023
Fix/suppress code analysis warnings in OpenTelemetry.Contrib.Extensions.PersistentStorage. Contributes to #950. Co-authored-by: Cijo Thomas <[email protected]>
Thanks @martincostello for your contributions! We are working through them one-by-one. Please expect some delay as we need each component owner (some of them are not approvers in this repo) to sign-off before merging. |
utpilla
pushed a commit
that referenced
this issue
Feb 22, 2023
Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.Quartz. Contributes to #950.
utpilla
pushed a commit
that referenced
this issue
Feb 22, 2023
Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.MySqlData. Contributes to #950.
utpilla
pushed a commit
that referenced
this issue
Feb 22, 2023
Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.Hangfire. Contributes to #950.
utpilla
pushed a commit
that referenced
this issue
Feb 22, 2023
Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.GrpcCore. Contributes to #950.
utpilla
pushed a commit
that referenced
this issue
Feb 22, 2023
Fix/suppress code analysis warnings in OpenTelemetry.Contrib.Exporter.Stackdriver. Contributes to #950.
utpilla
pushed a commit
that referenced
this issue
Feb 22, 2023
* [Shared] Fix analysis warnings Fix/suppress code analysis warnings in OpenTelemetry.Contrib.Shared. Contributes to #950. * Condense IDisposable implemnetation Apply code review feedback and put the code to dispose inline. ---------
This was referenced Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Is your feature request related to a problem?
As originally suggested by #900 (comment), enable
AnalysisLevel=latest-All
for all of the assemblies to find and then fix common problematic/buggy code patterns.Describe the solution you'd like:
Set
<AnalysisLevel>latest-All</AnalysisLevel>
inbuild/Common.props
and fix all of the resulting issues.Describe alternatives you've considered.
None.
Additional Context
Initially implemented as #908, but requested to be carved into multiple pull requests by #908 (comment).
PRs to port the changes from #908 project-by-project to follow.
The text was updated successfully, but these errors were encountered: