Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress two analysis warnings #1061

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Suppress two analysis warnings #1061

merged 3 commits into from
Mar 3, 2023

Conversation

martincostello
Copy link
Contributor

  • Suppress two code analysis warnings.
  • Fix TODO in XML comment.
  • Fix typos in XML comment.

Contributes to #950.

- Suppress two code analysis warnings.
- Fix TODO in XML comment.
- Fix typos in XML comment.
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zivaninstana, please review.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1061 (ed2debb) into main (6dc0417) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files         203      203           
  Lines        7783     7783           
=======================================
  Hits         5439     5439           
  Misses       2344     2344           
Impacted Files Coverage Δ
...xporter.Instana/TracerProviderBuilderExtensions.cs 0.00% <ø> (ø)

@utpilla utpilla merged commit 0c7f2a0 into open-telemetry:main Mar 3, 2023
@martincostello martincostello deleted the issue-950-suppress-analysis-warnings branch March 3, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants