Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress two analysis warnings #1061

Merged
merged 3 commits into from
Mar 3, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,25 @@
namespace OpenTelemetry.Exporter.Instana;

/// <summary>
/// Todo.
/// Extension methods for <see cref="TracerProviderBuilder"/> for using Instana.
/// </summary>
public static class TracerProviderBuilderExtensions
{
/// <summary>
/// Instana test provider builder extension.
/// Instana tracer provider builder extension.
/// </summary>
/// <param name="options">Test provider builder.</param>
/// <param name="options">Tracer provider builder.</param>
/// <returns>todo.</returns>
/// <exception cref="ArgumentNullException">Test provider builder is null.</exception>
/// <exception cref="ArgumentNullException">Tracer provider builder is null.</exception>
public static TracerProviderBuilder AddInstanaExporter(this TracerProviderBuilder options)
{
if (options == null)
{
throw new ArgumentNullException(nameof(options));
}

#pragma warning disable CA2000
return options.AddProcessor(new BatchActivityExportProcessor(new InstanaExporter()));
#pragma warning restore CA2000
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,9 @@ public void DisableMetricNameValidationTest(bool disableMetricNameValidation)
finally
{
instrumentNameRegexProperty.SetValue(null, initialInstrumentNameRegexValue);
#pragma warning disable CA1508
server?.Dispose();
#pragma warning restore CA1508
}
}

Expand Down