Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AnalysisLevel latest-All #969

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Enable AnalysisLevel latest-All #969

merged 6 commits into from
Mar 14, 2023

Conversation

martincostello
Copy link
Contributor

@martincostello martincostello commented Feb 3, 2023 •
edited
Loading

Changes

  • Enable AnalysisLevel at latest-All.
  • Add relevant suppressions for test projects.

Resolves #950.

Depends on:

This was referenced Feb 3, 2023
Closed
Merged
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 11, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 19, 2023
@Kielek Kielek reopened this Feb 19, 2023
@github-actions github-actions bot removed the Stale label Feb 20, 2023
@utpilla utpilla mentioned this pull request Feb 24, 2023
Closed
@martincostello martincostello marked this pull request as ready for review March 10, 2023 21:18
@martincostello martincostello requested a review from a team March 10, 2023 21:18
@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@9afb1e1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 47d1baf differs from pull request most recent head 62f05e8. Consider uploading reports for the commit 62f05e8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage        ?   70.18%           
=======================================
  Files           ?      210           
  Lines           ?     7864           
  Branches        ?        0           
=======================================
  Hits            ?     5519           
  Misses          ?     2345           
  Partials        ?        0

@utpilla
Copy link
Contributor

utpilla commented Mar 14, 2023

@martincostello Thanks a lot for working on this so patiently. #875 was merged before this which made some updates to two of the test files in AWSXRay project. This resulted in some merge conflicts. Could you please resolve them and we can merge this PR?

@martincostello
Enable AnalysisLevel latest-All
56eb6f0 
- Enable `AnalysisLevel` at `latest-All`.
- Add relevant suppressions for test projects.

Resolves #950.
@martincostello
Fix analysis warnings
6a26950 
Remove null-forgiving operator on two objects that are not null.
@martincostello
Fix rebase
e444046 
Fix incorrect merge conflict resolution.
@martincostello
Fix code analysis warnings
a8f86c6 
Fix code analysis warnings from culture-sensitive string comparisons and an undisposed handler.
@martincostello
Copy link
Contributor Author

It would be good if this can be merged (once green) before any other PRs, as other PRs are unintentionally introducing new analysis warnings that I then need to fix here.

@utpilla utpilla merged commit 79d8297 into open-telemetry:main Mar 14, 2023
@martincostello martincostello deleted the issue-950-enable-analysers branch March 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@utpilla utpilla utpilla approved these changes

Assignees

@srprash srprash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable AnalysisLevel=latest-All and fix resulting issues
4 participants
@martincostello @utpilla @Kielek @srprash