[Shared] Fix analysis warnings #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
approved these changes
Feb 3, 2023
CodeBlanch
reviewed
Feb 3, 2023
| @@ -87,11 +89,11 @@ public void OnError(Exception error) | |||
| /// <inheritdoc/> | |||
| public void Dispose() | |||
| { | |||
| this.Dispose(true); | |||
| this.DisposeInternal(); | |||
There was a problem hiding this comment.
nit: Just FYI in a sealed class you can slim down the disposal pattern. This would be fine:
public void Dispose()
{
if (Interlocked.CompareExchange(ref this.disposed, 1, 0) == 1)
{
return;
}
lock (this.listenerSubscriptions)
{
foreach (var listenerSubscription in this.listenerSubscriptions)
{
listenerSubscription?.Dispose();
}
this.listenerSubscriptions.Clear();
}
this.allSourcesSubscription?.Dispose();
this.allSourcesSubscription = null;
}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
- Coverage 69.39% 68.95% -0.44%
==========================================
Files 200 199 -1
Lines 7636 7589 -47
==========================================
- Hits 5299 5233 -66
- Misses 2337 2356 +19
|
Fix/suppress code analysis warnings in OpenTelemetry.Contrib.Shared. Contributes to #950.
Apply code review feedback and put the code to dispose inline.
utpilla
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix/suppress code analysis warnings in OpenTelemetry.Contrib.Shared.
Contributes to #950.