Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.EntityFrameworkCore] Fix analysis warning #962

Merged
merged 2 commits into from
Feb 14, 2023
Merged

[Instrumentation.EntityFrameworkCore] Fix analysis warning #962

merged 2 commits into from
Feb 14, 2023

Conversation

martincostello
Copy link
Contributor

Changes

Fix code analysis warning in OpenTelemetry.Instrumentation.EntityFrameworkCore.

Contributes to #950.

@martincostello martincostello requested a review from a team February 3, 2023 15:36
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #962 (b2f0986) into main (fab1a17) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files         184      184           
  Lines        7013     7013           
=======================================
  Hits         4777     4777           
  Misses       2236     2236           
Impacted Files Coverage Δ
...eworkCore/EntityFrameworkInstrumentationOptions.cs 100.00% <100.00%> (ø)

Fix code analysis warning in OpenTelemetry.Instrumentation.EntityFrameworkCore.
Contributes to #950.
@cijothomas cijothomas merged commit 4d7f93e into open-telemetry:main Feb 14, 2023
@martincostello martincostello deleted the issue-950-analysers-efcore branch February 14, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants