Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNet] Fix analysis warnings #960

Merged
merged 2 commits into from
Feb 7, 2023
Merged

[Instrumentation.AspNet] Fix analysis warnings #960

merged 2 commits into from
Feb 7, 2023

Conversation

martincostello
Copy link
Contributor

Changes

Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.AspNet.

Contributes to #950.

@martincostello martincostello requested a review from a team February 3, 2023 15:32
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #960 (12ffe63) into main (8ee613c) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

❗ Current head 12ffe63 differs from pull request most recent head f3864e3. Consider uploading reports for the commit f3864e3 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   68.73%   68.37%   -0.36%     
==========================================
  Files         183      183              
  Lines        7026     7027       +1     
==========================================
- Hits         4829     4805      -24     
- Misses       2197     2222      +25     
Impacted Files Coverage Δ
....AspNet.TelemetryHttpModule/TelemetryHttpModule.cs 5.26% <0.00%> (-0.15%) ⬇️
...mentation.AspNet/MeterProviderBuilderExtensions.cs 100.00% <ø> (ø)
...sions.PersistentStorage/PersistentStorageHelper.cs 69.69% <0.00%> (-18.19%) ⬇️
...ctions/PersistentStorageAbstractionsEventSource.cs 8.33% <0.00%> (-16.67%) ⬇️
...s.PersistentStorage.Abstractions/PersistentBlob.cs 38.09% <0.00%> (-14.29%) ⬇️
...y.Extensions.PersistentStorage/FileBlobProvider.cs 77.41% <0.00%> (-6.46%) ⬇️
...orter.Geneva/TLDExporter/UncheckedASCIIEncoding.cs 15.68% <0.00%> (-0.32%) ⬇️
....PersistentStorage/PersistentStorageEventSource.cs 19.64% <0.00%> (ø)
...Telemetry.Extensions.PersistentStorage/FileBlob.cs 84.09% <0.00%> (+8.53%) ⬆️

Fix/suppress code analysis warnings in OpenTelemetry.Instrumentation.AspNet.
Contributes to #950.
Create `AspNetMetrics` in the func to remove code analysis warning.
@cijothomas cijothomas merged commit 2cf37da into open-telemetry:main Feb 7, 2023
@martincostello martincostello deleted the issue-950-analysers-aspnet branch February 7, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants