Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AnalysisLevel=latest-All and fix resulting issues #4144

Closed
martincostello opened this issue Feb 3, 2023 · 2 comments
Closed

Enable AnalysisLevel=latest-All and fix resulting issues #4144

martincostello opened this issue Feb 3, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@martincostello
Copy link
Contributor

Feature Request

Is your feature request related to a problem?

As originally suggested by open-telemetry/opentelemetry-dotnet-contrib#900 (comment), enable AnalysisLevel=latest-All for all of the assemblies to find and then fix common problematic/buggy code patterns.

Describe the solution you'd like:

Set <AnalysisLevel>latest-All</AnalysisLevel> in build/Common.props and fix all of the resulting issues.

Describe alternatives you've considered.

None.

Additional Context

Initially implemented as #908, but requested to be carved into multiple pull requests by open-telemetry/opentelemetry-dotnet-contrib#908 (comment).

PRs to port the changes from #908 project-by-project to follow.
@martincostello martincostello added the enhancement New feature or request label Feb 3, 2023
@martincostello
Copy link
Contributor Author

Sorry, just realised I opened this in the wrong repo...🤦

@martincostello
Copy link
Contributor Author

open-telemetry/opentelemetry-dotnet-contrib#950

@martincostello martincostello closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martincostello