Use Array.Empty<T>()

[martincostello]

Changes

Use Array.Empty<string>() instead of allocating a new array.

• Appropriate CHANGELOG.md updated for non-trivial changes
• Design discussion issue #

[codecov]

Codecov Report

Merging #900 (903b53d) into main (6e38cfd) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 903b53d differs from pull request most recent head fba5626. Consider uploading reports for the commit fba5626 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   68.55%   68.44%   -0.12%     
==========================================
  Files         183      182       -1     
  Lines        6981     6952      -29     
==========================================
- Hits         4786     4758      -28     
+ Misses       2195     2194       -1     

Impacted Files	Coverage Δ
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs	88.05% <100.00%> (ø)
...ensions.AzureMonitor/ApplicationInsightsSampler.cs

[Oberon00]

This looks like something that could & should be checked by a linter BTW. Any rules we could enable to catch this automatically?

[martincostello]

There's a built-in rule for this (I forget the number) in fairly recent versions of the .NET SDK (6+ at latest) that should detect such usage if enabled.

[Kielek]

I suppose that it can be detected if you enable <AnalysisLevel>latest-All</AnalysisLevel> in csproj. See for main repository: open-telemetry/opentelemetry-dotnet#3958.

The warning: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1825

[martincostello]

I'd be happy to do a PR to enable that separately - I think otherwise turning it on might find other unrelated diagnostics that need fixing and quickly make the scope of this otherwise small PR spiral.

[martincostello]

I suppose that it can be detected if you enable <AnalysisLevel>latest-All</AnalysisLevel> in csproj. See for main repository: open-telemetry/opentelemetry-dotnet#3958.

The warning: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1825

Have opened #908 to enable analysers.