v6.11.2 proposal #14356
Merged
v6.11.2 proposal #14356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tries to make it simpler to add unit tests (cctest) for code that needs to test node core funtionality but that might not be appropriate as an addon or a JavaScript test. An example of this could be adding functionality targeted for situations when Node itself is embedded. Currently it was not as easy, or efficient, as one would have hoped to add such tests. The object output directories vary for different operating systems which we need to link to so that we don't have an additional compilation step. PR-URL: #11956 Backport-PR-URL: #12948 Ref: #9163 Reviewed-By: James M Snell <[email protected]>
This commit attempts to fix an issue when building on windows using the following command line options: .\vcbuild.bat dll debug x64 vc2015 This will result in the following options passed to configure: configure --debug --shared --dest-cpu=x64 --tag= This commit excludes the dependency to openssl if node is configured with --shared. Also, FP_API to the categories to export in mkssldef when generating the module definition (openssl.def) allowing the build to compile and link successfully. Fixes: #12952 PR-URL: #13078 Backport-PR-URL: #12948 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #11167 Backport-PR-URL: #13054 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #11658 Backport-PR-URL: #13054 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: #11697 Backport-PR-URL: #13054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Refactor test for situations where it was expected to fail. Move from disabled directory to parallel. PR-URL: #12403 Backport-PR-URL: #13060 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
This is a partial backport of semver-patch bits of 9e4660b. This commit fixes the Node process crashing when constructors of classes of the zlib module are given invalid options. * Throw an Error when the zlib library rejects the value of windowBits, instead of crashing with an assertion. * Treat windowBits and memLevel options consistently with other ones and don't crash when non-numeric values are given. PR-URL: #13098 Backport-PR-URL: #13201 Fixes: #13082 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Functions that call `ECDH::BufferToPoint` were not clearing the error stack on failure, so an invalid key could leave leftover error state and cause subsequent (unrelated) signing operations to fail. PR-URL: #13275 Backport-PR-URL: #13397 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
This is a local patch because upstream fixed it differently by moving large chunks of code out of objects.h. We cannot easily back-port those changes due to their size and invasiveness. Fixes: #10388 PR-URL: #12392 Backport-PR-URL: #13574 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
The test uses common.PORT, and has already been deleted on master. PR-URL: #13580 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
They tend to hang if they happen to run in parallel with another test that uses common.PORT. PR-URL: #13592 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #10944 Backport-PR-URL: #13751 Reviewed-By: Josh Gavant <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #12102 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #12109 Reviewed-By: James M Snell <[email protected]>
Ref: #9399 PR-URL: #11681 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1. necessarily reliably => necessarily reliable 2. projects root directory => project's root directory 3. remove `console` highlighting, as `test` alone is highlighted 4. fix broken link for Android NDK 5. highlight the directory location `/usr/local/ssl/fips-2.0` 6. update expected output to an example for `process.versions.openssl` as the version displayed is not mentioned in the document PR-URL: #11963 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
This commit adds C++ tests for `base64_encode()` and `base64_decode()` functions defined in `base64.h`. The functionality is already being tested indirectly in JavaScript tests for Buffer, but it won't hurt to test the low-level functions too, especially given that they aren't only used in the internal Buffer implementation, Chrome inspector protocol support relies upon them too. PR-URL: #12238 Refs: #12146 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Use no-restricted-syntax to implement the requirement that `Error` objects must be thrown with the `new` keyword. PR-URL: #12249 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Remove tls_server.js that has been disabled for about 6 years. It appears to have worked in concert with some other file which has since been removed. It seems to create a server and set up a bunch of listeners, but it does not appear to have code that connects to the server and triggers any of those listeners. PR-URL: #12275 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Replace custom lint rule for `assert.fail()` function signature errors with a restricted-syntax rule. PR-URL: #12287 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sometimes, after a cluster or debug test fails, a fixture hangs around and holds onto a needed port, causing subsequent CI runs to fail. This adds a command I've been running manually when this occurs. The command will clear the stalled jobs before a CI run. PR-URL: #11246 Backport-PR-URL: #13754 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Josh Gavant <[email protected]>
PR-URL: #12294 Fixes: #12291 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
It's only used once at startup in a single place so create the string in place instead of caching it for the lifetime of the isolate. PR-URL: #9213 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Check that invoking a callback on a receiver from a different context works. It ran afoul of an `env->context() == isolate->GetCurrentContext()` assertion so retrieve the environment from the callback context and the context to enter from the environment's context() method. We could also have retrieved the environment from the receiver's context and that would have made little practical difference. It just seemed more correct to get it from the callback context because that is the actual execution context. PR-URL: #9221 Reviewed-By: Anna Henningsen <[email protected]>
This test was disabled in 2013 because it spams random IPs with UDP messages. We've been doing fine for four years without so let's delete it. PR-URL: #12330 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Using `xargs -r` on some platforms and `xargs` on others doesn't work, we can't guarantee whether xargs is GNU or not. Avoid the issue by only running kill if there are processes to clean. PR-URL: #12158 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
Running the addon tests before the parallel, sequential, etc. tests can be a problem if there is a bug in node that prevents the addon tests from running properly. When the addon tests fail for any reason, then none of the other tests (e.g. parallel, etc.) are executed. Running the addon tests last fixes this. Refs: #12031 PR-URL: #12062 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: #12406 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
fixes #11972 PR-URL: #12258 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
The v8 and test-hash-seed targets cannot be run in parallel because they need different copies of the deps/v8 directory. Ref: #14004 (comment) PR-URL: #14219 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* Take RegExp creation out of cycles. * Use test(), not match() in boolean context. * Remove redundant RegExp parts. Backport-PR-URL: #14348 PR-URL: #13536 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
force-pushed
the
v6.11.2-proposal
branch
from
73d89f9
to
7ae03cb
Compare
MylesBorins
added a commit
that referenced
this pull request
Jul 21, 2017
Notable Changes: Coming Soon PR-URL: #14356
|
A couple more backports have come in... time for another r.c. CI: https://ci.nodejs.org/job/node-test-pull-request/9289/ |
This is an initial step to eliminate most of parsing errors. Backport-PR-URL: #14067 PR-URL: #12563 Refs: #12557 (comment) Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Backport-PR-URL: #14067 PR-URL: #12563 Refs: #12557 (comment) Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
* Install [email protected] * Add doc/.eslintrc.yaml * Add `plugins: [markdown]` to the main .eslintrc.yaml * .js files in doc folder added to .eslintignore * Update Makefile, vcbuild.bat, and tools/jslint.js Refs: #12563 Refs: #12640 Refs: #14047 PR-URL: #14067 Reviewed-By: James Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
The `no-useless-regex-char-class-escape` custom lint rule was introduced as a less aggressive alternative to some enhancements that were introduced into ESLint. Those enhancements were blocking us from updating ESLint. However, they have since been relaxed and the custom rule is no longer needed. Remove it. Backport-PR-URL: #14360 PR-URL: #10561 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
In preparation for applying the more strict indentation linting available in ESLint 4.0.0, correct minor indentation issues in tools/eslint-rules/required-modules.js. This is the only file with indentation that does not conform to the stricter checks. Backport-PR-URL: #14360 PR-URL: #13758 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
ESLint 4.0.0 provides stricter (and more granular) indentation checking than previous versions. Apply the stricter indentation rules to the tools directory. Backport-PR-URL: #14360 PR-URL: #13758 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fix previously-unnoticed typo in `required-modules.js`. Backport-PR-URL: #14360 Refs: #13758 (comment) PR-URL: #13758 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. Backport-PR-URL: #14370 PR-URL: #13770 Reviewed-By: Colin Ihrig <[email protected]>
This option has been broken for almost a year when used with any of the vm.runIn.. family of functions, except for syntax errors. Backport-PR-URL: #14373 PR-URL: #13074 Reviewed-By: Anna Henningsen <[email protected]>
This fixes a race condition in the watchdog timer used for vm timeouts. The condition would terminate the main stack's execution instead of the code running under the sandbox. Backport-PR-URL: #14373 PR-URL: #13074 Reviewed-By: Anna Henningsen <[email protected]>
Backport-PR-URL: #14416 PR-URL: #13206 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
This commit allows self signed certificates to work with unix sockets by forwarding the rejectUnauthorized option. Backport-PR-URL: #14415 Fixes: #13470 PR-URL: #13505 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins
force-pushed
the
v6.11.2-proposal
branch
from
7ae03cb
to
64d986d
Compare
MylesBorins
added a commit
that referenced
this pull request
Jul 31, 2017
Notable Changes: Coming Soon PR-URL: #14356
|
Dropped a commit breaking windows CI CI: https://ci.nodejs.org/job/node-test-pull-request/9414/ edit: CI is green. Nothing in CITGM looks particularly out of the ordinary |
addaleax
approved these changes
Jul 31, 2017
jasnell
approved these changes
Jul 31, 2017
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.
Notable Changes:
* configure:
- add mips64el to valid_arch (Aditya Anand)
- #13620
* crypto:
- Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
- #13279
- #12402
- https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
- upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
- #12913
* http:
- parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
- #13206
- Agent construction can now be envoked without `new` (cjihrig)
- #12927
* zlib:
- node will now throw an Error when zlib rejects the value of windowBits,
instead of crashing (Alexey Orlenko)
- #13098
PR-URL: #14356
MylesBorins
force-pushed
the
v6.11.2-proposal
branch
from
456a93e
to
f15e124
Compare
MylesBorins
added a commit
that referenced
this pull request
Aug 1, 2017
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.
Notable Changes:
* configure:
- add mips64el to valid_arch (Aditya Anand)
- #13620
* crypto:
- Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
- #13279
- #12402
- https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
- upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
- #12913
* http:
- parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
- #13206
- Agent construction can now be envoked without `new` (cjihrig)
- #12927
* zlib:
- node will now throw an Error when zlib rejects the value of windowBits,
instead of crashing (Alexey Orlenko)
- #13098
PR-URL: #14356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-08-01, Version 6.11.2 'Boron' (LTS), @MylesBorins
This LTS release comes with 221 commits. This includes 80 which are test related,
52 which are doc related, 32 which are build / tool related and 10 commits which are updates to dependencies.
Notable Changes
new(cjihrig) #12927Commits
8d043876c1] - doc/tools: fix more type inconsistencies (Roman Reiss) #116978860117600] - addons: remove semicolons from after module definition (Gabriel Schulhof) #12919bb3f54771b] - benchmark: update an obsolete path (Vse Mozhet Byt) #129047cc68e2c62] - benchmark: add final clean-up to module-loader.js (Vse Mozhet Byt) #121020cc7addcb2] - benchmark,windows: TCP.readStart() meaningful only after completion (Refael Ackermann) #122588dec80211e] - build: run test-hash-seed at the end of test-v8 (Michaël Zasso) #14219bb1b06a4e5] - build: check for linter in bin rather than lib (Rich Trott) #13645f571868b1b] - build: fail linter if linting not available (Gibson Fahnestock) #13658b0c6bf829b] - build: use existing variable to reduce complexity (Bryce Baril) #2883ebbde61927] - build: xz tarball extreme compression (Peter Dave Hello) #10626a354134f6a] - build: ignore more VC++ artifacts (Refael Ackermann) #1320885829a65e8] - build: avoid /docs/api and /docs/doc/api upload (Rod Vagg) #129577bda9620c9] - build: simplifyifin setting of arg_paths (Refael Ackermann) #126532724fe34ef] - build: add static option to vcbuild.bat (Tony Rice) #127647458d4ef98] - build: disable -O3 for C++ coverage (Anna Henningsen) #124068b8bf39822] - build: avoid passing kill empty input in Makefile (Gibson Fahnestock) #12158914f368efd] - build: clear stalled jobs on POSIX CI hosts (Rich Trott) #11246890e210a5f] - build: fix openssl link error on windows (Daniel Bevenius) #130783bb117e310] - build: enable cctest to use generated objects (Daniel Bevenius) #11956e5ca046c0a] - build, doc, tools: add eslint-plugin-markdown (Vse Mozhet Byt) #14067b46cf35526] - child_process: fix deoptimizing use of arguments (Vse Mozhet Byt) #11535edbe442938] - cluster, dns, repl, tls, util: fix RegExp nits (Vse Mozhet Byt) #13536a5f3b6fa7c] - configure: add mips64el to valid_arch (Aditya Anand) #136203b44e5e32c] - crypto: return CHECK_OK in VerifyCallback (Daniel Bevenius) #132411bfd177f09] - crypto: update root certificates (Ben Noordhuis) #13279b6f3581ea4] - crypto: update root certificates (Ben Noordhuis) #124021d509801e9] - crypto: throw proper errors if out enc is UTF-16 (Anna Henningsen) #127528f8dd97072] - crypto: clear err stack after ECDH::BufferToPoint (Ryan Kelly) #132753891759afc] - deps: update openssl asm and asm_obsolete files (Shigeki Ohtsu) #1291392583c4c81] - deps: cherry-pick 4ae5993 from upstream OpenSSL (Shigeki Ohtsu) #12913ee40a73d44] - deps: update openssl asm and asm_obsolete files (Daniel Bevenius) #13233a6a85c49c3] - deps: update openssl config files (Daniel Bevenius) #13233a579a776a3] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#1836b937c41405] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#138969570d370a] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#13895703d22849] - deps: copy all openssl header files to include dir (Daniel Bevenius) #1323377a9198aca] - deps: upgrade openssl sources to 1.0.2l (Daniel Bevenius) #132335b4c431365] - deps: add example of comparing OpenSSL changes (Daniel Bevenius) #1323418cbee236d] - dns: fix crash using dns.setServers after resolve4 (XadillaX) #130508c0849d5db] - doc: conform to rules for eslint-plugin-markdown (Vse Mozhet Byt) #125637deb259ccb] - doc: prepare js code for eslint-plugin-markdown (Vse Mozhet Byt) #1256359eb761797] - doc: document and test that methods return this (Sam Roberts) #13553fcb27fa7a1] - doc: remove leftover WHATWG url.format section (Roman Reiss) #14351e400ef9a76] - doc: don't suggest setEncoding for binary streams (Rick Bullotta) #11363092bba5cbf] - doc: update backporting guide (Refael Ackermann) #13749e2abda87f5] - doc: mention rebasing of v?.x-staging post release (Anna Henningsen) #1374224feb333c8] - doc:path.relativeusescwd(DuanPengfei) #1371471581e9308] - doc: small makeover for onboarding.md (Anna Henningsen) #134138f430e774b] - doc: note that EoL platforms are not supported (Gibson Fahnestock) #126729fa70069b3] - doc: use HTTPS URL for suggested upstream remote (Nikolai Vavilov) #13602fa209323af] - doc: update new CTC members (Refael Ackermann) #13534054f8cdc4d] - doc: corrects reference to tlsClientError (Tarun) #1353317da29ce84] - doc: emphasize Collaborators in GOVERNANCE.md (Rich Trott) #13423aea953abc2] - doc: minimal documentation for Emeritus status (Rich Trott) #1342142a42c0892] - doc: remove note highlighting in GOVERNANCE doc (Rich Trott) #13420cc492c361f] - doc: resume a stream after pipe() and unpipe() (Matteo Collina) #13329ae00f25a69] - doc: suggest xcode-select --install (Gibson Fahnestock) #132648daab3be31] - doc: remove 'you' from writing-tests.md (Michael Dawson) #13319f2ede07f17] - doc: add tniessen to collaborators (Tobias Nießen) #13371a33c6759b6] - doc: create list of CTC emeriti (Rich Trott) #132323745fbaa5d] - doc: remove Gitter badge from README (Rich Trott) #13231a7b51af049] - doc: make spelling of behavior consistent (Michael Dawson) #13245277de4257d] - doc: add jasongin & kunalspathak to collaborators (Jason Ginchereau) #13200fb07fbcc81] - doc: don't use useless constructors in stream.md (Vse Mozhet Byt) #13145cb03bd1f48] - doc: update code example for Windows in stream.md (Vse Mozhet Byt) #13138079b04e58d] - doc: improve formatting of STYLE_GUIDE.md (Alexey Orlenko) #131355f87252969] - doc: fix incorrect keyboard shortcut (Alexey Orlenko) #13134d4edc82aa5] - doc: edit Error.captureStackTrace html comment (Artur Vieira) #129621f9713362d] - doc: add additional useful ci job to list (Michael Dawson) #130862d5e2e9cab] - doc: document method for reverting commits (Gibson Fahnestock) #13015b31e6dfef5] - doc: update COLLABORATOR_GUIDE.md (morrme) #12555b854d27330] - doc: Change options at STEP 5 in CONTRIBUTING.md (kysnm) #12830c01a2d545e] - doc: add docs for server.address() for pipe case (Flarna) #1290783f272d4ee] - doc: fix typo in streams.md (Glenn Schlereth) #1292428add410c2] - doc: improve path.posix.normalize docs (Steven Lehn) #12700023ec46d2c] - doc: remove test-npm from general build doc (Rich Trott) #1284074a6929938] - doc: upgrade Clang requirement to 3.4.2 (Michaël Zasso) #123885b379e0aad] - doc: clarify the callback arguments of dns.resolve (Roman Reiss) #9532f6e58c35b2] - doc: add missing make command to UPGRADING.md (Daniel Bevenius) #13233a7869541e4] - doc: increase Buffer.concat() documentation (cjihrig) #118453b1d9112e0] - doc: update readFileSync in fs.md (Aditya Anand) #12800bc66495061] - doc: document vm timeout option perf impact (Anna Henningsen) #12751a3ae360ea6] - doc: modernize and fix code examples in repl.md (Vse Mozhet Byt) #126342435af9db6] - doc: update os.uptime() and process.uptime() info (Vse Mozhet Byt) #12294b2e58b6c7a] - doc: minor improvements in BUILDING.md (Sakthipriyan Vairamani (thefourtheye)) #119637ba172f56f] - doc: argument types for https methods (Amelia Clarke) #11681eb9e281b6b] - doc: update output examples in debugger.md (Vse Mozhet Byt) #10944b62cec8b02] - doc: linkify type[] syntax, support lowercase for primitives (Roman Reiss) #11167dd1fb98bda] - doc: consistent case for primitive types (Roman Reiss) #11167c43866954e] - doc,build: update configure help messages (Gibson Fahnestock) #129780d35bcdf84] - doc,stream: clarify 'data', pipe() and 'readable' (Matteo Collina) #13432351be2d5a8] - dtrace: resolve conversion warnings from SLURP_INT (Christopher J. Brody) #10143046bd79cf7] - events: remove unreachable code (cjihrig) #125018bf64d135f] - events: do not keep arrays with a single listener (Luigi Pinca) #12043f66f09f5d1] - http: describe parse err in debug output (Sam Roberts) #13206cab1285ccf] - http: fix first body chunk fast case for UTF-16 (Anna Henningsen) #1274701302989a7] - https: support rejectUnauthorized for unix sockets (cjihrig) #13505d51cd61713] - https: support agent construction without new (cjihrig) #129275eb11ba73e] - lib: correct typo in createSecureContext (Daniel Bevenius) #13653102671823c] - lib: "iff" changed to "if and only if" (Jacob Jones) #134961609c7f0c5] - lib: remove useless default caught (Jackson Tian) #12884ef133b36c5] - lib,test: use regular expression literals (Rich Trott) #128070cb5bd7268] - meta: fix nits in README.md collaborators list (Vse Mozhet Byt) #128664c51d969ee] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#138947e702059d] - os,vm: fix segfaults and CHECK failure (Tobias Nießen) #12371c97b167f47] - profiler: declare missingprintErr(Fedor Indutny) #13590bd323a71a8] - repl: fix /dev/null history file regression (Brian White) #12762b2acb81016] - repl: support hidden history file on Windows (Bartosz Sosnowski) #1220779592fe44a] - src: correct indentation for X509ToObject (Daniel Bevenius) #1354369143ffcf9] - src: make IsConstructCall checks consistent (Daniel Bevenius) #1347348f00b5170] - src: add comment for TicketKeyCallback (Anna Henningsen) #1319337e1929257] - src: check IsConstructCall in TLSWrap constructor (Daniel Bevenius) #130972e23da1a12] - src: remove unused node_buffer.h include (Daniel Bevenius) #1309541661287f2] - src: split CryptoPemCallback into two functions (Daniel Bevenius) #12827f92e065d12] - src: assert that uv_async_init() succeeds (cjihrig) #13116f43c969061] - src: turn buffer type-CHECK into exception (Anna Henningsen) #1275319259f46d0] - src: rename CryptoPemCallback -> PasswordCallback (Daniel Bevenius) #127877aa5a993b2] - src: make cross-context MakeCallback() calls work (Ben Noordhuis) #9221b1dc2d455f] - src: remove superfluous env_string string (Ben Noordhuis) #921348a923af37] - stream: remove unnecessary parameter (Leo) #127679cfec4ba0f] - test: fix RegExp nits (Vse Mozhet Byt) #13770a3e2560f7a] - test: mark test-npm-install flaky on arm (Refael Ackermann) #140358a7f13bd00] - test: mark test-fs-readdir-ucs2 flaky (João Reis) #1398934fc7a03d2] - test: change deprecated method to recommended (Rich Trott) #13649ef3698cad8] - test: refactor test-cluster-worker-isconnected.js (cjihrig) #13685fa75be7901] - test: fix nits in test-fs-mkdir-rmdir.js (Vse Mozhet Byt) #136809e9a9c342c] - test: increase bufsize in child process write test (Rich Trott) #1362653b345c506] - test: fix flaky test-tls-socket-close (Rich Trott) #13529a37165a2cc] - test: exercise once() with varying arguments (cjihrig) #13524779402ec5f] - test: validate full error messages (aniketshukla) #134537190d06d1f] - test: add known_test request with Unicode in the URL (David D Lowe) #13297cbcc9c1bbf] - test: add coverage for socket write after close (cjihrig) #1317147d59e7f97] - test: fix sequential test-net-connect-local-error (Sebastian Plesciuc) #130641d3596561b] - test: bind to 0 in dgram-send-callback-buffer-length (Artur Vieira) #129437909c6d46f] - test: use dynamic port in test-dgram-send-callback-buffer (Artur Vieira) #1294292cc96fa6b] - test: allow for absent nobody user in setuid test (Rich Trott) #13112253c5aa794] - test: move net reconnect error test to sequential (Artur G Vieira) #13033e279eb5aa3] - test: ignore spurious 'EMFILE' (Refael Ackermann) #126983e5e38e868] - test: use dynamic port in test-cluster-dgram-reuse (Artur Vieira) #129015fe68402bd] - test: refactor test-vm-new-script-new-context (Akshay Iyer) #130352aa68282fc] - test: track callback invocations (Rich Trott) #130100c83573b61] - test: add a simple abort check in windows (Sreepurna Jasti) #1291407137ab4db] - test: fix too optimistic guess in setproctitle (Vse Mozhet Byt) #127927419338b33] - test: make the rest of tests path-independent (Vse Mozhet Byt) #12972ac400a7b09] - test: check curve algorithm is supported (Karl Cheng)5b74e635e5] - test: reduce string concatenations (Vse Mozhet Byt) #12735c902265b90] - test: fix parallel/test-setproctitle.js on alpine (David Cai) #1241350bb452510] - test: fixed flaky test-net-connect-local-error (Sebastian Plesciuc) #129640cf3e10ce2] - test: remove unneeded string splitting (Vse Mozhet Byt) #129926e7b77fdbb] - test: use mustCall in tls-connect-given-socket (vperezma) #12592c10525c562] - test: add not-called check to heap-profiler test (Rich Trott) #129852451665157] - test: move test-dgram-bind-shared-ports to sequential (Rafael Fragoso) #12452d35648ffc2] - test: use dynamic port in test-https-connect-address-family (Artur G Vieira) #129151cd41e7a56] - test: dynamic port in cluster disconnect (Sebastian Plesciuc) #12545d71de281fa] - test: detect all types of aborts in windows (Gireesh Punathil) #12856d743783875] - test: use assert regexp in tls no cert test (Artur Vieira) #1289129d35d0ef1] - test: use dynamic port instead of common.PORT (Aditya Anand) #12473186c0758b3] - test: added net.connect lookup type check (Luca Maraschi) #11873c35f4909f4] - test: remove unused testpy code (Rich Trott) #1284452b7d5ecb1] - test: refactor test-querystring (Łukasz Szewczak) #126618414659d02] - test: refactoring test with common.mustCall (weewey) #12702608c30913e] - test: refactored test-repl-persistent-history (cool88) #12703aaf8044a81] - test: remove common.PORT in test tls ticket cluster (Oscar Martinez) #12715802a945d81] - test: add mustCall in timers-unrefed-in-callback (Zahidul Islam) #12594739c579134] - test: fix flakyness withyes.exe(Refael Ackermann) #1282114e835831f] - test: dynamic port in dgram tests (Sebastian Plesciuc) #12623361bc845dc] - test: verify listener leak is only emitted once (cjihrig) #12502f236dcbdd9] - test: move WPT to its own testing module (Rich Trott) #127364eb28c80e8] - test: introducecommon.crashOnUnhandledRejection(Anna Henningsen) #124892411318f60] - test: add second argument to assert.throws (Michaël Zasso) #12270eca9e72a87] - test: add regex in test_cyclic_link_protection (Clarence Dimitri CHARLES) #116226020e720b5] - test: improve test-fs-open-flags (Vinícius do Carmo) #10908e6d6a4111c] - test: extended test to makeCallback cb type check (Luca Maraschi) #12140d74019d98d] - test: improve test-crypto-rsa-dsa (Adrian Estrada) #10681bab8a36f94] - test: improve the code in test-crypto-dh (Adrian Estrada) #10734752bc24943] - test: validate errors in test-buffer-indexof (Adrian Estrada) #107529e7f02187a] - test: improve test-buffer-includes.js (toboid) #11203c309bb0695] - test: validate error message from buffer.equals (Sebastian Roeder) #1121562c56806fc] - test: add msg validation to test-buffer-compare (Josh Hollandsworth) #10807fc9e7a98ed] - test: make tests cwd-independent (Vse Mozhet Byt) #12812fff0e39933] - test: add regex check in test-vm-is-context (jeyanthinath) #1278574dc86d239] - test: add callback to fs.close() in test-fs-stat (Vse Mozhet Byt) #12804a47a9b7cf4] - test: add callback to fs.close() in test-fs-chmod (Vse Mozhet Byt) #12795eefa840118] - test: increase readline coverage (Anna Henningsen) #1276154decfa2ce] - test: replace indexOf with includes (gwer) #1260403adb94ee6] - test: dynamic port in parallel regress tests (Sebastian Plesciuc) #126398a59f6b038] - test: dynamic port in cluster worker wait close (Sebastian Plesciuc) #124660383048b76] - test: fix coverity UNINIT_CTOR cctest warning (Ben Noordhuis) #12387f2467edc62] - test: remove common.PORT from multiple tests (Tarun Batra) #12451a23aca4f12] - test: replace [].join() with ''.repeat() (Jackson Tian) #12305e512906aab] - test: run the addon tests last (Sebastian Van Sande) #12062abc2c82bf3] - test: remove disabled test-dgram-send-error (Rich Trott) #12330d9866ce9c7] - test: remove disabled tls_server.js (Rich Trott) #1227519d95519c7] - test: add basic cctest for base64.h (Alexey Orlenko) #1223801073bc26a] - test: add internal/socket_list tests (DavidCai) #12109a5fe098b85] - test: move common.PORT debug tests to sequential (Gibson Fahnestock) #135920b8adedb88] - test: move test-debug-brk to sequential (Gibson Fahnestock) #1358097b6911ade] - test: enable setuid/setgid test (Rich Trott) #124034dff12849f] - test,doc: documentcrashOnUnhandledRejection()(Anna Henningsen) #126997e6a956a29] - test,lib,doc: use function declarations (Rich Trott) #12711910fa50e0e] - tools: fix error in custom ESLint rule (Rich Trott) #13758bb74da309c] - tools: apply stricter indentation rules to tools (Rich Trott) #1375804934b04c3] - tools: fix indentation in required-modules.js (Rich Trott) #13758550577749f] - tools: remove no-useless-regex-char-class-escape (Rich Trott) #105614ffe804c81] - tools: update ESLint to v4.0.0 (Rich Trott) #13645fb214bbcff] - tools: be explicit about including key-id (Myles Borins) #13309f831015928] - tools: update certdata.txt (Ben Noordhuis) #13279bc2e73a05f] - tools: update certdata.txt (Ben Noordhuis) #1240299da83b54d] - tools: relax lint rule for regexps (Rich Trott) #128073d564a4ed1] - tools: require function declarations (Rich Trott) #127116afa5fe348] - tools: add table parsing capability to the doctool (Roman Reiss) #95329c67032b9a] - tools: enforce two arguments in assert.throws (Michaël Zasso) #1227095d13d59e4] - tools: remove unused code from test.py (Rich Trott) #1280670e9058a8e] - tools: ignore node_trace.*.log (Daijiro Wachi) #1275461427471af] - tools: replace custom assert.fail lint rule (Rich Trott) #12287b2a08fb130] - tools: replace custom new-with-error rule (Rich Trott) #12249beb8485998] - tools: fix lint issue in doctool (Roman Reiss) #11658d9a8f80c0d] - v8: fix build errors with g++ 7 (Zuzana Svetlikova) #123928b3aacc96a] - vm: fix race condition with timeout param (Marcel Laverdet) #130746e60c838c9] - vm: fix displayErrors in runIn.. functions (Marcel Laverdet) #1307455cbe24c60] - zlib: fix node crashing on invalid options (Alexey Orlenko) #13098