doc: remove test-npm from general build doc #12840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
`make test-npm` is not particularly robust (currently fails on Linux and Windows, reportedly) and results in a fair number of requests for help from people new to the project. It is used when upgrading npm in core, which only a small number of mostly-predefined people do. Remove it from the general build doc. Refs: nodejs#12836
addaleax
approved these changes
May 5, 2017
Fishrock123
approved these changes
May 5, 2017
jasnell
approved these changes
May 5, 2017
lpinca
approved these changes
May 5, 2017
cjihrig
approved these changes
May 5, 2017
danbev
approved these changes
May 5, 2017
|
Landed in a398516 |
addaleax
pushed a commit
that referenced
this pull request
May 7, 2017
`make test-npm` is not particularly robust (currently fails on Linux and Windows, reportedly) and results in a fair number of requests for help from people new to the project. It is used when upgrading npm in core, which only a small number of mostly-predefined people do. Remove it from the general build doc. Refs: #12836 PR-URL: #12840 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
`make test-npm` is not particularly robust (currently fails on Linux and Windows, reportedly) and results in a fair number of requests for help from people new to the project. It is used when upgrading npm in core, which only a small number of mostly-predefined people do. Remove it from the general build doc. Refs: nodejs#12836 PR-URL: nodejs#12840 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Not sure if this would have helped with finding out npm/npm#16734, but somewhere we need to regression test |
|
Ref: #11540 |
@refack No because the test doesn't work on Windows and 16734 is a Windows issue. This was a documentation-only PR. No tests were removed or anything like that. I think comments on the quality or effectiveness of our npm testing in general should go in a separate issue. |
Ack. My comment wasn't directly related to this PR, definatly not critique, I just needed a thread with context, and I only found #11540 later (mostly had a guilty mind / hindsight is always 20/20 etc.) |
3 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
`make test-npm` is not particularly robust (currently fails on Linux and Windows, reportedly) and results in a fair number of requests for help from people new to the project. It is used when upgrading npm in core, which only a small number of mostly-predefined people do. Remove it from the general build doc. Refs: #12836 PR-URL: #12840 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
`make test-npm` is not particularly robust (currently fails on Linux and Windows, reportedly) and results in a fair number of requests for help from people new to the project. It is used when upgrading npm in core, which only a small number of mostly-predefined people do. Remove it from the general build doc. Refs: #12836 PR-URL: #12840 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test-npmis not particularly robust (currently fails on Linux andWindows, reportedly) and results in a fair number of requests for help
from people new to the project. It is used when upgrading npm in core,
which only a small number of mostly-predefined people do. Remove it from
the general build doc.
Checklist
Affected core subsystem(s)
doc