test: detect all types of aborts in windows #12856
Conversation
|
It looks like this already needs a rebase 😄 |
|
@addaleax - I don't know what would have caused this (branch conflict), and how to resolve it. Any pointers please? |
|
|
On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3
gireeshpunathil
force-pushed
the
windowsabortcodes
branch
from
157b7b8
to
bd0e41a
Compare
|
@addaleax - thanks! I guess I did it right. |
|
@gireeshpunathil could you write a few words about how come tests haven't been failing? And do we need a test that aborts with code 3? |
|
@refack - if (exports.isWindows) {
expectedExitCodes = [3221225477];
+ console.log('XXX');
+ console.trace();
}With this change I ran the entire unit tests ( Looks like we never have a test case which aborts in Windows either through JS process.abort(), or through C++ Assert(FALSE), or through --abort-on-uncaught-exception If you propose I can add one. |
|
@gireeshpunathil thank you. IMHO adding a test would be great. |
|
Lande in 6914aea |
On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: #12856 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
thanks all! |
No, thank you 🥇 |
|
There seems to be a |
|
I was having Git tech difficulties the other day. It was after my first PR got merged I believe. |
|
@gibfahn That wasn’t me, I just saw the ref in a
@arturgvieira You couldn’t, this is definitely not something you have caused. :) It’s not a big deal anyway. |
|
@addaleax I see, thanks, I feel much better |
|
two days ago (EDT time) |
On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: nodejs#12856 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: #12856 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: #12856 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
On Windows, 'aborts' are of 2 types, depending on the context:
(i) Forced access violation, if --abort-on-uncaught-exception is on
which corresponds to exit code 3221225477 (0xC0000005)
(ii) raise(SIGABRT) or abort(), which lands up in CRT library calls
which corresponds to exit code 3
For background, please refer to #12823
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test