test: detect all types of aborts in windows

On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: #12856 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Jul 11, 2017 · d71de28 · d71de28
1 parent c01a2d5
commit d71de28
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/test/common/index.js b/test/common/index.js
@@ -506,10 +506,13 @@ exports.nodeProcessAborted = function nodeProcessAborted(exitCode, signal) {
   // or SIGABRT (depending on the compiler).
   const expectedSignals = ['SIGILL', 'SIGTRAP', 'SIGABRT'];
 
-  // On Windows, v8's base::OS::Abort triggers an access violation,
+  // On Windows, 'aborts' are of 2 types, depending on the context:
+  // (i) Forced access violation, if --abort-on-uncaught-exception is on
   // which corresponds to exit code 3221225477 (0xC0000005)
+  // (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls
+  // which corresponds to exit code 3.
   if (exports.isWindows)
-    expectedExitCodes = [3221225477];
+    expectedExitCodes = [3221225477, 3];
 
   // When using --abort-on-uncaught-exception, V8 will use
   // base::OS::Abort to terminate the process.