Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL have collisions in node.dll #12952

Closed
gamelaster opened this issue May 10, 2017 · 6 comments
Closed

OpenSSL have collisions in node.dll #12952

gamelaster opened this issue May 10, 2017 · 6 comments
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs. regression Issues related to regressions. windows Issues and PRs related to the Windows platform.

Comments

@gamelaster
Copy link

  • Version: v7.7.1 (on PC)
  • Platform: Windows 10 64-bit

NodeJS latest (7.10.0) source (downloaded source as tar.gz), Visual Studio 2015, Python 2.7.13 32-bit, Launch:
.\vcbuild.bat dll debug x64 vc2015

image
(sorry, I closed terminal already)
@mscdex mscdex added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels May 10, 2017
@refack
Copy link
Contributor

refack commented May 10, 2017

@gamelaster I'm trying to repro.
It might be a bug in our build scaffolding; since you are building as dll, cctest tries to link with both the node.dll and openSSL.lib.

  • Note 1: cctest is just our C++ test harness, most probably you got the node.dll target built fine.
  • Note 2: if you really want to build cctest, edit it's vcxproj file and try to remove the dual library, and rebuild.

@gamelaster
Copy link
Author

@refack yes, node.dll has been build successfully. I don't need cctest, but I don't see in vcbuild how disable it

@refack
Copy link
Contributor

refack commented May 10, 2017 •
edited
Loading

I'm not sure there's a way. but it really doesn't matter. the next thing that would have run are the test, and I'm not sure we have an automated way to test the dll

@refack refack self-assigned this May 10, 2017
@gamelaster
Copy link
Author

@refack So how I should run test? I tested already node.dll and it's works

@refack
Copy link
Contributor

refack commented May 10, 2017

That's it...
I'm assuming you are interested in the dll and not the exe.

@refack
Copy link
Contributor

refack commented May 10, 2017

If you want to be doubly sure run
vcbuild.bat debug x64 vc2015 (without the dll arg)
that will reuse as much as possible of the previously built artifacts and build node.exe that the automated test can use

@refack refack mentioned this issue May 11, 2017
Closed
2 tasks
@refack refack added confirmed-bug Issues with confirmed bugs. regression Issues related to regressions. labels May 13, 2017
This was referenced May 13, 2017
Closed
Closed
@danbev danbev mentioned this issue May 17, 2017
Closed
2 tasks
danbev added a commit to danbev/node that referenced this issue May 24, 2017
@danbev
build: fix openssl link error on windows
13515e5 
This commit attempts to fix an issue when building on windows using the
following command line options:
.\vcbuild.bat dll debug x64 vc2015

This will result in the following options passed to configure:
configure --debug --shared --dest-cpu=x64 --tag=

This commit excludes the dependency to openssl if node is configured
with --shared.

Also, FP_API to the categories to export in mkssldef when generating
the module definition (openssl.def) allowing the build to compile and
link successfully.

Fixes: nodejs#12952
@danbev danbev closed this as completed in 1cde375 May 25, 2017
jasnell pushed a commit that referenced this issue May 25, 2017
@danbev @jasnell
build: fix openssl link error on windows
79c0244 
This commit attempts to fix an issue when building on windows using the
following command line options:
.\vcbuild.bat dll debug x64 vc2015

This will result in the following options passed to configure:
configure --debug --shared --dest-cpu=x64 --tag=

This commit excludes the dependency to openssl if node is configured
with --shared.

Also, FP_API to the categories to export in mkssldef when generating
the module definition (openssl.def) allowing the build to compile and
link successfully.

Fixes: #12952
PR-URL: #13078
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
jasnell pushed a commit that referenced this issue May 28, 2017
@danbev @jasnell
build: fix openssl link error on windows
46bd32e 
This commit attempts to fix an issue when building on windows using the
following command line options:
.\vcbuild.bat dll debug x64 vc2015

This will result in the following options passed to configure:
configure --debug --shared --dest-cpu=x64 --tag=

This commit excludes the dependency to openssl if node is configured
with --shared.

Also, FP_API to the categories to export in mkssldef when generating
the module definition (openssl.def) allowing the build to compile and
link successfully.

Fixes: #12952
PR-URL: #13078
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
danbev added a commit to danbev/node that referenced this issue May 30, 2017
@danbev
build: fix openssl link error on windows
c364725 
This commit attempts to fix an issue when building on windows using the
following command line options:
.\vcbuild.bat dll debug x64 vc2015

This will result in the following options passed to configure:
configure --debug --shared --dest-cpu=x64 --tag=

This commit excludes the dependency to openssl if node is configured
with --shared.

Also, FP_API to the categories to export in mkssldef when generating
the module definition (openssl.def) allowing the build to compile and
link successfully.

Fixes: nodejs#12952
PR-URL: nodejs#13078
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
gibfahn pushed a commit to gibfahn/node that referenced this issue Jun 17, 2017
@danbev @gibfahn
build: fix openssl link error on windows
adb9bfb 
This commit attempts to fix an issue when building on windows using the
following command line options:
.\vcbuild.bat dll debug x64 vc2015

This will result in the following options passed to configure:
configure --debug --shared --dest-cpu=x64 --tag=

This commit excludes the dependency to openssl if node is configured
with --shared.

Also, FP_API to the categories to export in mkssldef when generating
the module definition (openssl.def) allowing the build to compile and
link successfully.

Fixes: nodejs#12952
PR-URL: nodejs#13078
Backport-PR-URL: nodejs#12948
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this issue Jul 11, 2017
@danbev @MylesBorins
build: fix openssl link error on windows
890e210 
This commit attempts to fix an issue when building on windows using the
following command line options:
.\vcbuild.bat dll debug x64 vc2015

This will result in the following options passed to configure:
configure --debug --shared --dest-cpu=x64 --tag=

This commit excludes the dependency to openssl if node is configured
with --shared.

Also, FP_API to the categories to export in mkssldef when generating
the module definition (openssl.def) allowing the build to compile and
link successfully.

Fixes: #12952
PR-URL: #13078
Backport-PR-URL: #12948
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@refack refack removed their assignment Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs. regression Issues related to regressions. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix openssl link error on windows danbev/node
3 participants
@mscdex @refack @gamelaster