-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,build: update configure help messages #12978
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Issues and PRs related to build files or the CI.
label
May 11, 2017
cc/ @refack @sam-github |
richardlau
approved these changes
May 11, 2017
thefourtheye
approved these changes
May 11, 2017
refack
approved these changes
May 11, 2017
I still want |
cjihrig
approved these changes
May 11, 2017
jasnell
approved these changes
May 11, 2017
Trott
reviewed
May 11, 2017
configure
Outdated
@@ -430,7 +430,7 @@ parser.add_option('--without-snapshot', | |||
parser.add_option('--without-ssl', | |||
action='store_true', | |||
dest='without_ssl', | |||
help='build without SSL') | |||
help='build without SSL (disables crypto, https, inspector etc.)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: comma after inspector
lpinca
approved these changes
May 12, 2017
refack
approved these changes
May 12, 2017
- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: nodejs#12978 Refs: nodejs#12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced May 26, 2017
refack
pushed a commit
to refack/node
that referenced
this pull request
May 26, 2017
- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: nodejs#12978 Refs: nodejs#12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in e5e581c |
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: #12978 Refs: #12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
- The V8 inspector is no longer experimental. - Note that building without SSL disables other features. PR-URL: #12978 Refs: #12768 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #12768 (comment)
Checklist
Affected core subsystem(s)
doc, build