Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: tweak addon tests #12031

Closed
mscdex opened this issue Mar 25, 2017 · 2 comments
Closed

test: tweak addon tests #12031

mscdex opened this issue Mar 25, 2017 · 2 comments
Labels
addons Issues and PRs related to native addons. good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests.

Comments

@mscdex
Copy link
Contributor

mscdex commented Mar 25, 2017 •
edited
Loading

  • Version: all
  • Platform: n/a
  • Subsystem: test

Currently we run the addon tests before the parallel, sequential, etc. tests which can be a problem if there is a bug in node that prevents the addon tests from running properly. When the addon tests fail for any reason, then none of the other tests (e.g. parallel, etc.) are executed.

So I propose we either allow test execution to continue when any of the addon tests fail (saving the status code in case the rest of the tests should pass) or we simply move the addon tests to run after the parallel, etc. tests.

/cc @nodejs/collaborators
@mscdex mscdex added good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. addons Issues and PRs related to native addons. labels Mar 25, 2017
@bnoordhuis
Copy link
Member

Let's go with the easiest solution: run the addon tests last.

@seppevs seppevs mentioned this issue Mar 27, 2017
Closed
2 tasks
seppevs added a commit to seppevs/node that referenced this issue Apr 4, 2017
@seppevs
test: run the addon tests last
9149610 
Running the addon tests before the parallel, sequential, etc. tests
can be a problem if there is a bug in node that prevents the
addon tests from running properly. When the addon tests fail for any
reason, then none of the other tests (e.g. parallel, etc.)
are executed.

Running the addon tests last fixes this.

Refs: nodejs#12031
refack pushed a commit to refack/node that referenced this issue Apr 13, 2017
@seppevs @refack
test: run the addon tests last
3d2181c 
Running the addon tests before the parallel, sequential, etc. tests
can be a problem if there is a bug in node that prevents the
addon tests from running properly. When the addon tests fail for any
reason, then none of the other tests (e.g. parallel, etc.)
are executed.

Running the addon tests last fixes this.

Refs: nodejs#12031
PR-URL: nodejs#12062
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
gibfahn pushed a commit that referenced this issue Jun 18, 2017
@seppevs @gibfahn
test: run the addon tests last
f359682 
Running the addon tests before the parallel, sequential, etc. tests
can be a problem if there is a bug in node that prevents the
addon tests from running properly. When the addon tests fail for any
reason, then none of the other tests (e.g. parallel, etc.)
are executed.

Running the addon tests last fixes this.

Refs: #12031
PR-URL: #12062
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
gibfahn pushed a commit that referenced this issue Jun 20, 2017
@seppevs @gibfahn
test: run the addon tests last
50ebe1a 
Running the addon tests before the parallel, sequential, etc. tests
can be a problem if there is a bug in node that prevents the
addon tests from running properly. When the addon tests fail for any
reason, then none of the other tests (e.g. parallel, etc.)
are executed.

Running the addon tests last fixes this.

Refs: #12031
PR-URL: #12062
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@benjamingr
Copy link
Member

This work item has already been done.

MylesBorins pushed a commit that referenced this issue Jul 11, 2017
@seppevs @MylesBorins
test: run the addon tests last
e512906 
Running the addon tests before the parallel, sequential, etc. tests
can be a problem if there is a bug in node that prevents the
addon tests from running properly. When the addon tests fail for any
reason, then none of the other tests (e.g. parallel, etc.)
are executed.

Running the addon tests last fixes this.

Refs: #12031
PR-URL: #12062
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @bnoordhuis @benjamingr