Skip to content

Commit

Permalink
test: dynamic port in cluster worker wait close
Browse files Browse the repository at this point in the history
Remove common.PORT from test-cluster-worker-wait-server-close
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12466
Ref: #12376
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
  • Loading branch information
Sebastian Plesciuc authored and MylesBorins committed Jul 11, 2017
1 parent 0383048 commit 8a59f6b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/parallel/test-cluster-worker-wait-server-close.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ if (cluster.isWorker) {
// Wait for any data, then close connection
socket.write('.');
socket.on('data', function discard() {});
}).listen(common.PORT, common.localhostIPv4);
}).listen(0, common.localhostIPv4);

server.once('close', function() {
serverClosed = true;
Expand All @@ -33,8 +33,8 @@ if (cluster.isWorker) {
const worker = cluster.fork();

// Disconnect worker when it is ready
worker.once('listening', function() {
const socket = net.createConnection(common.PORT, common.localhostIPv4);
worker.once('listening', function(address) {
const socket = net.createConnection(address.port, common.localhostIPv4);

socket.on('connect', function() {
socket.on('data', function() {
Expand Down

0 comments on commit 8a59f6b

Please sign in to comment.