Update default browser strings #7180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhasin2
commented
Aug 21, 2020
| public static let DefaultBrowserCardTitle = NSLocalizedString("DefaultBrowserCard.Title", tableName: "Default Browser", value: "Switch Your Default Browser", comment: "Title for small card shown that allows user to switch their default browser to Firefox.") | ||
| public static let DefaultBrowserCardDescription = NSLocalizedString("DefaultBrowserCard.Description", tableName: "Default Browser", value: "Set links from websites, emails, and Messages to open automatically in Firefox.", comment: "Description for small card shown that allows user to switch their default browser to Firefox.") | ||
| public static let DefaultBrowserCardButton = NSLocalizedString("DefaultBrowserCard.Button", tableName: "Default Browser", value: "Go to Settings", comment: "Button string to open settings that allows user to switch their default browser to Firefox.") | ||
| public static let DefaultBrowserMenuItem = NSLocalizedString("Settings.DefaultBrowserMenuItem", tableName: "Default Browser", value: "Set as Default Browser", comment: "Menu option for setting Firefox as default browser.") |
There was a problem hiding this comment.
Added menu string
nbhasin2
commented
Aug 21, 2020
| public static let DefaultBrowserCardTitle = NSLocalizedString("TodayWidget.DefaultBrowserCardTitle", tableName: "Default Browser", value: "Switch Your Default Browser", comment: "Title for small card shown that allows user to switch their default browser to Firefox.") | ||
| public static let DefaultBrowserCardDescription = NSLocalizedString("TodayWidget.DefaultBrowserCardDescription", tableName: "Default Browser", value: "Set links from websites, emails, and Messages to open automatically in Firefox.", comment: "Description for small card shown that allows user to switch their default browser to Firefox.") | ||
| public static let DefaultBrowserCardButton = NSLocalizedString("TodayWidget.DefaultBrowserCardButton", tableName: "Default Browser", value: "Go to Settings", comment: "Button string to open settings that allows user to switch their default browser to Firefox.") | ||
| public static let DefaultBrowserCardTitle = NSLocalizedString("DefaultBrowserCard.Title", tableName: "Default Browser", value: "Switch Your Default Browser", comment: "Title for small card shown that allows user to switch their default browser to Firefox.") |
There was a problem hiding this comment.
All others I just cleaned up key to reflect that its default browser string. Actual string remains the same.
dnarcese
approved these changes
Aug 21, 2020
vphong
added a commit
to vphong/firefox-ios
that referenced
this pull request
Aug 26, 2020
* main: (25 commits) FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051) FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215) Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216) FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164) Bug 1608838: Include data sensitivity category (mozilla-mobile#7112) Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158) Update default browser strings (mozilla-mobile#7180) FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971) Refactored small size search in title to be more clear (mozilla-mobile#7168) For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153) Added comments to new line strings for translators (mozilla-mobile#7162) For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155) Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157) Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038) Refactored some strings for v29 (mozilla-mobile#7152) Breach Alerts Feature (mozilla-mobile#7136) Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125) Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124) String update: Added missing serial comma (mozilla-mobile#7132) Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129) ...
garvankeeley
pushed a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.