Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXIOS-762 ⁃ Fix #5937: Re-enable more XCUI tests #7158

Merged
merged 1 commit into from
Aug 24, 2020
Merged

FXIOS-762 ⁃ Fix #5937: Re-enable more XCUI tests #7158

merged 1 commit into from
Aug 24, 2020

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Aug 18, 2020

Using Xcode 11.6, these tests now run and pass locally on simulator (iPhone 11 Pro). They were disabled for failing in Xcode 11.3. The others mentioned in #5937 are already enabled and running.

┆Issue is synchronized with this Jira Task

@AaronMT AaronMT self-assigned this Aug 18, 2020
@AaronMT AaronMT added the eng:automation This is a task or bug affecting the automated tests label Aug 18, 2020
@data-sync-user data-sync-user changed the title Fix #5937: Re-enable more XCUI tests FXIOS-762 ⁃ Fix #5937: Re-enable more XCUI tests Aug 21, 2020
Copy link
Contributor

@SimonBasca SimonBasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This can be safely squash and merged.

@AaronMT AaronMT merged commit 0f06c3c into mozilla-mobile:main Aug 24, 2020
@AaronMT AaronMT deleted the 5937-xcode-11.3-reenable-tests branch August 24, 2020 15:07
vphong added a commit to vphong/firefox-ios that referenced this pull request Aug 26, 2020
* main: (25 commits)
  FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051)
  FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215)
  Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216)
  FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164)
  Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)
  Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158)
  Update default browser strings (mozilla-mobile#7180)
  FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971)
  Refactored small size search in title to be more clear (mozilla-mobile#7168)
  For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153)
  Added comments to new line strings for translators (mozilla-mobile#7162)
  For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155)
  Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157)
  Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038)
  Refactored some strings for v29 (mozilla-mobile#7152)
  Breach Alerts Feature (mozilla-mobile#7136)
  Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125)
  Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124)
  String update: Added missing serial comma (mozilla-mobile#7132)
  Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng:automation This is a task or bug affecting the automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants