-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FXIOS-759 ⁃ Fix #7123: Empty logins view after switching to a different app #7164
Conversation
Not sure if this is a stable fix since I'm not sure why that behavior was written in in the first place. Any thoughts @garvankeeley? |
It is possible this may affect the behavior when you set face id and passcode as required to access logins? You can go to Firefox Settings and then scroll down to "Face ID & Passcode" and turn either Face ID or Passcode on and check to see if this breaks that security behavior @vphong |
The |
Does this patch still solve the STR in https://bugzilla.mozilla.org/show_bug.cgi?id=1562486 ? |
Yes, here's another recording using a passcode instead of Touch ID: https://imgur.com/a/YvibYr3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the video of this working!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for remedying this! Approving since this behavior is currently much better than crashing - but just want to note that @vphong chatted about trying to make the navigation bar dismissal a little smoother, if it's possible with the way the code is currently laid out.
Sorry, I was busy today but would just like to make sure this looks OK with my recent push: https://gfycat.com/negativegloomyharpseal @kaylagalway @garvankeeley |
Looks perfect. Thank you @vphong ! |
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
* main: (25 commits) FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051) FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215) Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216) FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164) Bug 1608838: Include data sensitivity category (mozilla-mobile#7112) Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158) Update default browser strings (mozilla-mobile#7180) FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971) Refactored small size search in title to be more clear (mozilla-mobile#7168) For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153) Added comments to new line strings for translators (mozilla-mobile#7162) For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155) Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157) Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038) Refactored some strings for v29 (mozilla-mobile#7152) Breach Alerts Feature (mozilla-mobile#7136) Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125) Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124) String update: Added missing serial comma (mozilla-mobile#7132) Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129) ...
Fixes #7123. Removes the "go to root view controller" behavior on app deactivation in
SensitiveViewController
whichLoginList
andLoginDetail
view controllers inherit from. That seemed to have prevented detecting app reactivation from the Login Details view.┆Issue is synchronized with this Jira Task