Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXIOS-640 ⁃ Show about:blank in URL bar for window.open #7000

Closed
garvankeeley opened this issue Jul 21, 2020 · 2 comments
Closed

FXIOS-640 ⁃ Show about:blank in URL bar for window.open #7000

garvankeeley opened this issue Jul 21, 2020 · 2 comments
Assignees
@garvankeeley
Labels
3 Story size Bug 🐞 This is a bug with existing functionality not behaving as expected QA Verified Issue verified by QA security

Comments

@garvankeeley
Copy link
Contributor

garvankeeley commented Jul 21, 2020 •
edited by data-sync-user
Loading

https://bugzilla.mozilla.org/show_bug.cgi?id=1634597

┆Issue is synchronized with this Jira Task
@garvankeeley garvankeeley added Bug 🐞 This is a bug with existing functionality not behaving as expected security labels Jul 21, 2020
@garvankeeley garvankeeley self-assigned this Jul 30, 2020
@garvankeeley garvankeeley added the 3 Story size label Jul 30, 2020
@data-sync-user data-sync-user changed the title Show about:blank in URL bar for window.open FXIOS-640 ⁃ Show about:blank in URL bar for window.open Aug 5, 2020
garvankeeley added a commit to garvankeeley/firefox-ios that referenced this issue Aug 12, 2020
@garvankeeley
Fix mozilla-mobile#7000: show about:blank for blank target popup windows
17c71ed
@SimonBasca
Copy link
Contributor

Tested on main 855dca8 on iPhone Xr 13.5

@garvankeeley I am not seeing "about:blank" in URL after following the STR:

  1. Go to blank.html
  2. Click "Click me"

Is this the correct behaviour?

Picture_2020_08_18T14_46_09_460Z

garvankeeley added a commit to garvankeeley/firefox-ios that referenced this issue Aug 25, 2020
@garvankeeley
Fix mozilla-mobile#7000: followup commit for about:blank popups, hand…
ca7edcf 
…le nil url
garvankeeley added a commit to garvankeeley/firefox-ios that referenced this issue Aug 25, 2020
@garvankeeley
Fix mozilla-mobile#7000: followup commit for about:blank popups, hand…
8807f5a 
…le nil url
@garvankeeley garvankeeley mentioned this issue Aug 25, 2020
Merged
vphong added a commit to vphong/firefox-ios that referenced this issue Aug 26, 2020
@vphong
Merge branch 'main' into issue#6312
aa5a90c 
* main: (25 commits)
  FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051)
  FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215)
  Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216)
  FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164)
  Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)
  Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158)
  Update default browser strings (mozilla-mobile#7180)
  FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971)
  Refactored small size search in title to be more clear (mozilla-mobile#7168)
  For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153)
  Added comments to new line strings for translators (mozilla-mobile#7162)
  For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155)
  Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157)
  Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038)
  Refactored some strings for v29 (mozilla-mobile#7152)
  Breach Alerts Feature (mozilla-mobile#7136)
  Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125)
  Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124)
  String update: Added missing serial comma (mozilla-mobile#7132)
  Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129)
  ...
garvankeeley added a commit that referenced this issue Sep 24, 2020
@garvankeeley
Fix #7000: followup commit for about:blank popups, handle nil url (#7201
c8e1817 
)
@SimonBasca
Copy link
Contributor

Fixed on c8e1817

@SimonBasca SimonBasca added the QA Verified Issue verified by QA label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garvankeeley garvankeeley

Labels
3 Story size Bug 🐞 This is a bug with existing functionality not behaving as expected QA Verified Issue verified by QA security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garvankeeley @SimonBasca