Fix #7000: show about:blank for blank target popup windows #7125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
garvankeeley
force-pushed
the
gk/bug-7000
branch
from
c006fc3
to
a6538fc
Compare
nbhasin2
reviewed
Aug 13, 2020
| @@ -47,6 +47,11 @@ class TabLocationView: UIView { | |||
| } | |||
|
|
|||
| func showLockIcon(forSecureContent isSecure: Bool) { | |||
| if (url?.absoluteString == "about:blank") { | |||
There was a problem hiding this comment.
Suggested change
| if (url?.absoluteString == "about:blank") { | |
| if url?.absoluteString == "about:blank" { |
nbhasin2
approved these changes
Aug 13, 2020
kaylagalway
approved these changes
Aug 13, 2020
garvankeeley
force-pushed
the
gk/bug-7000
branch
from
af713c0
to
666fbc7
Compare
vphong
added a commit
to vphong/firefox-ios
that referenced
this pull request
Aug 26, 2020
* main: (25 commits) FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051) FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215) Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216) FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164) Bug 1608838: Include data sensitivity category (mozilla-mobile#7112) Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158) Update default browser strings (mozilla-mobile#7180) FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971) Refactored small size search in title to be more clear (mozilla-mobile#7168) For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153) Added comments to new line strings for translators (mozilla-mobile#7162) For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155) Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157) Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038) Refactored some strings for v29 (mozilla-mobile#7152) Breach Alerts Feature (mozilla-mobile#7136) Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125) Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124) String update: Added missing serial comma (mozilla-mobile#7132) Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.