Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXIOS-779 ⁃ Empty logins view after switching to a different app #7123

Closed
csuciu opened this issue Aug 12, 2020 · 4 comments · Fixed by #7164
Closed

FXIOS-779 ⁃ Empty logins view after switching to a different app #7123

csuciu opened this issue Aug 12, 2020 · 4 comments · Fixed by #7164
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor OK This is a good issue for contributors interested in helping the project Crash Crashes the application P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA

Comments

@csuciu
Copy link

csuciu commented Aug 12, 2020 •
edited by data-sync-user
Loading

master cd7ef45/current release (v28.0)
iPhone 11 Pro 13.3

  1. Open the Logins view via Menu => Logins & Passwords.
  2. Tap on an saved login to enter the login details view.
  3. Switch to a different app then switch back to Firefox.

Result: The user is returned to the logins list view which is empty (the loading throbber is shown but the list doesn't populate )

Note: This issue doesn't occur if entering Logins & Passwords via the Settings page. In this case, following the STR the user is presented the Settings page when returning to Firefox.

┆Issue is synchronized with this Jira Task
@csuciu csuciu assigned csuciu and unassigned csuciu Aug 12, 2020
@csuciu csuciu added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Aug 13, 2020
@athomasmoz athomasmoz added Contributor OK This is a good issue for contributors interested in helping the project P2 Issues that need to be completed after all P1 issues are completed for the current release labels Aug 14, 2020
@vphong
Copy link
Contributor

vphong commented Aug 18, 2020 •
edited
Loading

Trying to reproduce this - this is what I get. Instead of going back to the Logins & Passwords list, the content just blurs and the app becomes unresponsive but doesn't crash. Can you confirm this on the latest build @csuciu?
IMG_0013

@csuciu
Copy link
Author

csuciu commented Aug 18, 2020

@vphong Confirming that, on latest master, the content blurs when returning to the app. After that, when I try to interact with the app, it crashes.
This is the crash report:
Client-2020-08-18-200445.ips.zip

@vphong
Copy link
Contributor

vphong commented Aug 19, 2020

Thank you @csuciu!

@vphong vphong mentioned this issue Aug 19, 2020
Merged
@data-sync-user data-sync-user changed the title Empty logins view after switching to a different app FXIOS-779 ⁃ Empty logins view after switching to a different app Aug 21, 2020
kaylagalway pushed a commit that referenced this issue Aug 25, 2020
@vphong
FXIOS-759 ⁃ Fix #7123: Empty logins view after switching to a differe…
324cf49 
…nt app (#7164)

* Update SensitiveViewController.swift and add more dismisses + animate for UI smoothness
vphong added a commit to vphong/firefox-ios that referenced this issue Aug 26, 2020
@vphong
Merge branch 'main' into issue#6312
aa5a90c 
* main: (25 commits)
  FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051)
  FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215)
  Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216)
  FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164)
  Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)
  Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158)
  Update default browser strings (mozilla-mobile#7180)
  FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971)
  Refactored small size search in title to be more clear (mozilla-mobile#7168)
  For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153)
  Added comments to new line strings for translators (mozilla-mobile#7162)
  For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155)
  Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157)
  Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038)
  Refactored some strings for v29 (mozilla-mobile#7152)
  Breach Alerts Feature (mozilla-mobile#7136)
  Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125)
  Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124)
  String update: Added missing serial comma (mozilla-mobile#7132)
  Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129)
  ...
@csuciu
Copy link
Author

csuciu commented Aug 27, 2020

Verifying as fixed on master c91e958.

@csuciu csuciu added the QA Verified Issue verified by QA label Aug 27, 2020
@data-sync-user data-sync-user added the Crash Crashes the application label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor OK This is a good issue for contributors interested in helping the project Crash Crashes the application P2 Issues that need to be completed after all P1 issues are completed for the current release QA Verified Issue verified by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FXIOS-759 ⁃ Fix #7123: Empty logins view after switching to a different app
4 participants
@csuciu @vphong @athomasmoz @data-sync-user