Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXIOS-213 ⁃ [XCUITests] New failures after Xcode 11.3 update #5937

Closed
isabelrios opened this issue Dec 20, 2019 · 4 comments
Closed

FXIOS-213 ⁃ [XCUITests] New failures after Xcode 11.3 update #5937

isabelrios opened this issue Dec 20, 2019 · 4 comments
Assignees
Labels
eng:automation This is a task or bug affecting the automated tests

Comments

@isabelrios
Copy link
Contributor

isabelrios commented Dec 20, 2019

There are several test suites affected:
-Tracking Protection: failure to open ETP menu from website
-Translation: Not possible to tap on the snackbar menu when loading a test site, it is possible if the site is a real one
-SyncUI: Elements in the fxa login view are not seen by the tests and so tests fail due to error in asserting the view/typing in Email field and similar
-Navigation: tests related with previous features (sync)
-HomePageSettings: error when trying to go to BrowserTabMenu

Investigating these issues and disabling the tests in the meantime...

┆Issue is synchronized with this Jira Task

@isabelrios isabelrios added the eng:automation This is a task or bug affecting the automated tests label Dec 20, 2019
@isabelrios
Copy link
Contributor Author

NewTabSettings: testChangeNewTabSettingsShowCustomURL, value in text field is not udpated with url value.

@isabelrios
Copy link
Contributor Author

Here a list of disabled/modified tests:
-testSearchEngine
-testChangeNewTabSettingsShowCustomURL
-testBookmarksAwesomeBar -> Disabled
-testTopSitesOpenInNewPrivateTabDefaultTopSite
-testTopSitesRemoveAllDefaultTopSitesAddNewOne
-testSetCustomURLAsHome
-testSetFirefoxHomeAsHome -> Disabled
-testTypeOnGivenFields-> Disabled
-testCreateAnAccountLink
-testShowPassword
-testSyncUIFromBrowserTabMenu
-testSnackBarDisplayed
-testTranslationDisabled
-testTranslateBing

@isabelrios
Copy link
Contributor Author

These are the tests still having a workaround or being disabled due to iOS 13.3. The rest were fixed after the 13.4 update. Most of these could be fixed too but not done yet.
-testSearchEngine
-testChangeNewTabSettingsShowCustomURL
-testBookmarksAwesomeBar -> Disabled
-testTopSitesOpenInNewPrivateTabDefaultTopSite
-testSetCustomURLAsHome
-testSetFirefoxHomeAsHome -> Disabled

@AaronMT
Copy link
Contributor

AaronMT commented Aug 18, 2020

I will try these out on Xcode 11.6 and see if they still fail on simulator. I'll post a PR for the ones that pass.

@AaronMT AaronMT self-assigned this Aug 18, 2020
@data-sync-user data-sync-user changed the title [XCUITests] New failures after Xcode 11.3 update FXIOS-213 ⁃ [XCUITests] New failures after Xcode 11.3 update Aug 21, 2020
vphong added a commit to vphong/firefox-ios that referenced this issue Aug 26, 2020
* main: (25 commits)
  FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051)
  FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215)
  Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216)
  FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164)
  Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)
  Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158)
  Update default browser strings (mozilla-mobile#7180)
  FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971)
  Refactored small size search in title to be more clear (mozilla-mobile#7168)
  For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153)
  Added comments to new line strings for translators (mozilla-mobile#7162)
  For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155)
  Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157)
  Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038)
  Refactored some strings for v29 (mozilla-mobile#7152)
  Breach Alerts Feature (mozilla-mobile#7136)
  Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125)
  Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124)
  String update: Added missing serial comma (mozilla-mobile#7132)
  Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng:automation This is a task or bug affecting the automated tests
Projects
None yet
Development

No branches or pull requests

2 participants