Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXIOS-699 ⁃ Land strings for iOS 14 Widgets #7091

Closed
athomasmoz opened this issue Aug 4, 2020 · 2 comments · Fixed by #7129
Closed

FXIOS-699 ⁃ Land strings for iOS 14 Widgets #7091

athomasmoz opened this issue Aug 4, 2020 · 2 comments · Fixed by #7129
Assignees
@nbhasin2
Labels
1 Story size

Comments

@athomasmoz
Copy link

athomasmoz commented Aug 4, 2020 •
edited by data-sync-user
Loading

Acceptance Criteria

┆Issue is synchronized with this Jira Task
@data-sync-user data-sync-user changed the title Land strings for iOS 14 Widgets FXIOS-699 ⁃ Land strings for iOS 14 Widgets Aug 5, 2020
@data-sync-user
Copy link
Collaborator

➤ Ashley Thomas commented:

[~[email protected]] [~[email protected]] Can you add the accessibility strings/hints to the mocks?

@betsymi
Copy link

betsymi commented Aug 12, 2020

Before these strings are sent to l10n, would it be possible for me to take a look to verify they're correct? Not sure the best way to do that. Normally I request screen shots, but I know there are quite a few for this one.

@nbhasin2 nbhasin2 self-assigned this Aug 12, 2020
@nbhasin2 nbhasin2 linked a pull request Aug 13, 2020 that will close this issue
Fix #7091 #7092 #7113 - String updates for Widgets, Default Browser and ETP changes #7129
Merged
@nbhasin2 nbhasin2 added the 1 Story size label Aug 13, 2020
nbhasin2 added a commit that referenced this issue Aug 13, 2020
@nbhasin2
Fix #7091 #7092 #7113 - String updates for Widgets, Default Browser a…
4ebb573 
…nd ETP changes (#7129)
noorhashem pushed a commit to noorhashem/firefox-ios that referenced this issue Aug 16, 2020
@nbhasin2 @noorhashem
Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - Str…
02a3c01 
…ing updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129)
vphong added a commit to vphong/firefox-ios that referenced this issue Aug 26, 2020
@vphong
Merge branch 'main' into issue#6312
aa5a90c 
* main: (25 commits)
  FXIOS-708 ⁃ [iOS14 Widgets] : iOS14 Quick Action Widgets (Medium/Small) Versions (mozilla-mobile#7051)
  FXIOS-805 ⁃ Default browser change, remove adjust, remove photopicker string (mozilla-mobile#7215)
  Revert "Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)" (mozilla-mobile#7216)
  FXIOS-759 ⁃ Fix mozilla-mobile#7123: Empty logins view after switching to a different app (mozilla-mobile#7164)
  Bug 1608838: Include data sensitivity category (mozilla-mobile#7112)
  Fix mozilla-mobile#5937: Re-enable more XCUI tests (mozilla-mobile#7158)
  Update default browser strings (mozilla-mobile#7180)
  FXIOS-714 ⁃ [Today Widget] Adding Close Private tabs button to today widget (mozilla-mobile#6971)
  Refactored small size search in title to be more clear (mozilla-mobile#7168)
  For mozilla-mobile#7130 - XCUITest fix Downloads tests (mozilla-mobile#7153)
  Added comments to new line strings for translators (mozilla-mobile#7162)
  For mozilla-mobile#7154 - UITests fix compilation error (mozilla-mobile#7155)
  Refactored strings for Quick Action - Small Size widget (mozilla-mobile#7157)
  Fix mozilla-mobile#6847 new tab button (mozilla-mobile#7038)
  Refactored some strings for v29 (mozilla-mobile#7152)
  Breach Alerts Feature (mozilla-mobile#7136)
  Fix mozilla-mobile#7000: show about:blank for blank target popup windows (mozilla-mobile#7125)
  Fix mozilla-mobile#7053: Add prompt visible UI test for HTTP Basic Auth (mozilla-mobile#7124)
  String update: Added missing serial comma (mozilla-mobile#7132)
  Fix mozilla-mobile#7091 mozilla-mobile#7092 mozilla-mobile#7113 - String updates for Widgets, Default Browser and ETP changes (mozilla-mobile#7129)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbhasin2 nbhasin2

Labels
1 Story size
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7091 #7092 #7113 - String updates for Widgets, Default Browser and ETP changes
4 participants
@nbhasin2 @athomasmoz @betsymi @data-sync-user