Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed KResponsiveWindow to useKResponsiveWindow in Pdf Viewer plugin #11415

Closed
wants to merge 306 commits into from
Closed

changed KResponsiveWindow to useKResponsiveWindow in Pdf Viewer plugin #11415

wants to merge 306 commits into from

Conversation

ShivangRawat30
Copy link
Contributor

Summary

This PR changes the KResponsiveWindow to useKResponsiveWindow in Pdf Viewer plugin

References

#11328

Reviewer guidance

…

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

marcellamaki and others added 30 commits October 10, 2023 15:38
@marcellamaki
conditionalize failure errors based on source device network availabi…
145a142 
…lity
@marcellamaki
PR feedback implementation
817324b
@marcellamaki
Update useDevices composable to contain a networkDevices object which…
4247069 
… polls for the currently available devices and can be shared across components and files
@marcellamaki
Misc. cleanup of downloads related files
a92e54e
@marcellamaki
refactor fetchDevices polling and networkDevices ref per feedback, to…
69d1c10 
… reduce potential async conflicts, overwriting, and errors
@marcellamaki
Refactor useDevices, and update ExploreLIbrariesPage to use the new n…
52b18fb 
…etworkDevices ref from the useDevices composable
@marcellamaki
Update references to baseurl, instanceId, and deviceName based on cha…
ed7b7f0 
…nges to useDevices composable, so that they continue to be imported correctly
@marcellamaki
Ensure networkDevices is correctly imported into DownloadsList, where…
25cd51a 
… it is used to conditionally set errors displayed to the user
@marcellamaki
Address review feedback
3387d79
@marcellamaki
Address PR feedback, fix downloads page reactivity problems
c348541
@marcellamaki
Update useDevices mock in accordance with composable updates
355bbe2
@marcellamaki
Fix error with topicsMore by setting as Boolean()
b6da8b3
@marcellamaki
Improve loading state on ExploreLibraries page by updating loading se…
b8ba2aa 
…t in handler, and adding a circular loader for page data
@marcellamaki
Update MyDownloads page to fetch before waiting for polling, and add …
781a58c 
…status column that displays On your device for successfully downloaded items
@marcellamaki
add icon for on device
234e6cd
@marcellamaki
Move setting page name and loading to after the logged in guard
c1686c1
@marcellamaki
Update Library page (which was not updated with new composable change…
8f45a20 
…s in useDevices; PR feedback and fixes
@marcellamaki
rename functions for clarity about responsibilities and purposes
c112a37
@marcellamaki
fix nextTick error
de98a18
@marcellamaki
Fix download pagination with re-fetch, to appropriately reset the pag…
d54cb3d 
…ination state on resource removal
@marcellamaki
Fix pagination redirect when no items left in the page
4f5c488
@marcellamaki
Ensure learner cannot download resource from content page when downlo…
31a08cc 
…ading is disabled
@nucleogenesis
provide/inject composable as quizForge - set quiz title on field bl…
b9bbc5c 
…ur evt
@nucleogenesis
tabs have options; addsection focuses new section;
23961db
@nucleogenesis
routing for side panels fixed; hooked into actual UI
8d22b1a
@nucleogenesis
first whack at porting component to tabs
0256cbf
@nucleogenesis
fix after busted rebase
7311456
@nucleogenesis
clean consolelogs, ensure keyboard outline shows in tabs inner-button…
47d30cb 
…s; skips outer
@nucleogenesis
new section is active section; tabs outline works; overflow works
14e998a
@nucleogenesis
oh boy; got tabs working w/ sub-menu for now; need styles and such to…
310b011 
… clean up
nucleogenesis and others added 14 commits October 25, 2023 13:10
@nucleogenesis
Merge pull request learningequality#11382 from nucleogenesis/feature-…
6dc82f3 
…-quiz-section-tabs-with-overflow

Merging this to mitigate rebase issues; @LianaHarris360 ' review notes will be handled in learningequality#11434 which is based on this PR
@rtibbles
Merge branch 'release-v0.16.x' into develop
fea24d0 
# Conflicts:
#	kolibri/core/auth/serializers.py
#	kolibri/core/package.json
#	kolibri/plugins/coach/assets/src/views/CoachImmersivePage.vue
#	kolibri/plugins/perseus_viewer/assets/src/views/PerseusRendererIndex.vue
#	yarn.lock
@marcellamaki
Merge pull request learningequality#11460 from rtibbles/0.16intodevelop
545323a 
0.16 into develop
@MisRob
Merge branch 'develop' into userResponseWindow-device-plugin
939bdce
@MisRob
Update taskpanel snapshot
20ea01f
@MisRob
Merge pull request learningequality#11349 from thesujai/userResponseW…
1bf619c 
…indow-device-plugin

Replace KResponseWindow with useKResponseWindow in Device plugin
@MisRob
Merge branch 'develop' into 11325
d32fca9
@MisRob
Merge branch 'develop' into userKResponsiveWindow-profile-page
dbc9bdd
@a6ar55 @MisRob
updated to useKResponsiveWindow
09c0b57
@a6ar55 @MisRob
fixed the typo and spacing errors
93ea572
@a6ar55 @MisRob
some more changes with syntax
146dea7
@MisRob
Merge pull request learningequality#11355 from ShivangRawat30/11325
60ca630 
replaced responsiveWindow with useKResponsiveWindow
@MisRob
Merge pull request learningequality#11427 from a6ar55/release-v0.16.x
db111b3 
Replaced KResponsiveWindow mixin by useKResponsiveWindow composable - Core learningequality#11335
@MisRob
Merge pull request learningequality#11358 from thesujai/userKResponsi…
e001ec0 
…veWindow-profile-page

Replace KResponseWindow with useKResponseWindow in User Profile plugin
@thanksameeelian
Copy link
Contributor

thanks for this, @ShivangRawat30! i can confirm the code looks correct.

just a couple steps before it can be officially approved & merged:

  • please merge in the latest develop into your branch, it should resolve the failing tests/conflicts 🙂
  • once that has been done & tests are passing, i will tag QA & ask them to confirm accurate page responsiveness in the PDF viewer now that the composable is in use.

@thesujai @rtibbles
Replace KResponsiveWindowMixin with useKResponseWindow in Learn plugin (
cb1a8ea 
learningequality#11366)

* MyDownloads page done

* ActivityFilter done

* SortFilter done

* View Folder resources

* BookmarkPage done

* ContentPage done

* resolved conflict in LearningActivityBars

* Library page done

* search result grid done

* Assesment wrapper done

* LessonMasteryBar done

* CardGrid view done

* LessonPlaylistPage done

* CompletionModalSection done

* ExamPage done

* bug fix

* QuizRenderer

* category search model done

* CardList view done

* conflict resolved TopicsPage

* contenet grid done

* All conflict resolved

* for completion modal

* SidePanel modal

* regression fixed

* resolved

* ActivityFilter done

* lLibrary page done

* search result grid done

* regression fixed

* fixes while rebasing

* Fix tests.

---------

Co-authored-by: Richard Tibbles <[email protected]>
@MisRob
Copy link
Member

MisRob commented Nov 10, 2023

Hi @ShivangRawat30, can we help here somehow?

@ShivangRawat30
Copy link
Contributor Author

@MisRob I will look into it, I wasn't active because of my exams.

@MisRob
Copy link
Member

MisRob commented Nov 10, 2023

Okay, take all the time you need and good luck with exams. Thanks for letting us know.

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanksameeelian thanksameeelian Awaiting requested review from thanksameeelian

Assignees
No one assigned
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment SIZE: medium SIZE: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.