Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KResponseWindow with useKResponseWindow in Learn plugin #11366

Merged
merged 32 commits into from
Nov 1, 2023
Merged

Replace KResponseWindow with useKResponseWindow in Learn plugin #11366

merged 32 commits into from
Nov 1, 2023

Conversation

thesujai
Copy link
Contributor

@thesujai thesujai commented Oct 7, 2023 •
edited
Loading

Summary

For testing:

  1. First Identified where ResponsiveWindow elements are are used
  2. Then play with CSS class of components that will be used when windowBreakpoint is reached.
  3. Then verify that the CSS tweaks is consistent with both KResponsiveWindow and userKResponsiveWindow
  4. Roll back the CSS tweaks made while testing

Page and component effected:

  • /en/learn/my-downloads#/
  • /en/learn/#/library
  • /en/learn/#/home/classes (All subpages like /lesson,/quizes)
  • Content Pages(quizes, lessons, activitybar etc)
  • Exam page
  • Select a topic -> View Folder Resources

…

References

Fixes #11324

…

Reviewer guidance

Would it be possible to add a hacktoberfest-accepted label in this PR?
Here is the link: https://hacktoberfest.com/participation/#maintainers
Its fine if for some reasons you aren't able to do so:)
…

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: medium labels Oct 7, 2023
rtibbles
rtibbles reviewed Oct 8, 2023
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code changes look correct to me. (searching for window in changed files).

@rtibbles
Copy link
Member

rtibbles commented Oct 8, 2023

This needs to be rebased on top of latest develop.

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) SIZE: large labels Oct 9, 2023
@thesujai
Copy link
Contributor Author

thesujai commented Oct 9, 2023

@rtibbles have a look

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.0b6.dev0_git.545.g131813f5.pex
Windows Installer (EXE) kolibri-0.16.0b6.dev0+git.545.g131813f5-unsigned.exe
Debian Package kolibri_0.16.0b6.dev0+git.545.g131813f5-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.0b6.dev0+git.545.g131813f5-0.3.0.dmg
Android Package (APK) kolibri-0.16.0b6.dev0+git.545.g131813f5-0.1.0-debug.apk
TAR file kolibri-0.16.0b6.dev0+git.545.g131813f5.tar.gz
WHL file kolibri-0.16.0b6.dev0+git.545.g131813f5-py2.py3-none-any.whl

@thesujai thesujai force-pushed the userKResponsiveWindow-learn branch from 6efc3a6 to ed6822c Compare October 9, 2023 13:08
@github-actions github-actions bot removed DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) labels Oct 9, 2023
@rtibbles rtibbles added the hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest label Oct 11, 2023
@rtibbles rtibbles force-pushed the userKResponsiveWindow-learn branch from 928c024 to 0e05f90 Compare November 1, 2023 00:30
@rtibbles rtibbles merged commit cb1a8ea into learningequality:develop Nov 1, 2023
34 checks passed
@rtibbles rtibbles mentioned this pull request Nov 1, 2023
Closed
poju3185 pushed a commit to poju3185/kolibri that referenced this pull request Mar 15, 2024
@thesujai @rtibbles @poju3185
Replace KResponsiveWindowMixin with useKResponseWindow in Learn plugin (
5287423 
learningequality#11366)

* MyDownloads page done

* ActivityFilter done

* SortFilter done

* View Folder resources

* BookmarkPage done

* ContentPage done

* resolved conflict in LearningActivityBars

* Library page done

* search result grid done

* Assesment wrapper done

* LessonMasteryBar done

* CardGrid view done

* LessonPlaylistPage done

* CompletionModalSection done

* ExamPage done

* bug fix

* QuizRenderer

* category search model done

* CardList view done

* conflict resolved TopicsPage

* contenet grid done

* All conflict resolved

* for completion modal

* SidePanel modal

* regression fixed

* resolved

* ActivityFilter done

* lLibrary page done

* search result grid done

* regression fixed

* fixes while rebasing

* Fix tests.

---------

Co-authored-by: Richard Tibbles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees
No one assigned
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest SIZE: large SIZE: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesujai @rtibbles