Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Learn plugin #11324

Closed
Tracked by #11321
MisRob opened this issue Sep 29, 2023 · 5 comments
Closed
Tracked by #11321

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Learn plugin #11324

MisRob opened this issue Sep 29, 2023 · 5 comments
Assignees
@thesujai
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Milestone
Kolibri 0.17: Gen...

Comments

@MisRob
Copy link
Member

MisRob commented Sep 29, 2023

This is one of the issues whose common goal is to gradually replace KResponsiveWindow mixin by useKResponsiveWindow composable.

First, see #11321 for detailed instructions and acceptance criteria common to all issues.

Then, replace KResponsiveWindow mixin by useKResponsiveWindow composable in all .vue files of the Learn plugin (/kolibri/plugins/learn)
@MisRob MisRob added P2 - normal Priority: Nice to have DEV: frontend help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Sep 29, 2023
@MisRob MisRob mentioned this issue Sep 29, 2023
Closed
4 tasks
@thesujai
Copy link
Contributor

thesujai commented Oct 2, 2023

@MisRob Please, assign this to me

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

Hi @thesujai, thank you. I already assigned you some other issues. You're welcome to remind yourself here again as soon as you've finished them (explained more in one of the comments I left you).

@thesujai
Copy link
Contributor

thesujai commented Oct 5, 2023

Hey @MisRob, as I finished my other assigned issue, I will be working on this

@MisRob
Copy link
Member Author

MisRob commented Oct 6, 2023

Okay, @thesujai, thanks

@thesujai thesujai mentioned this issue Oct 7, 2023
Merged
9 tasks
@rtibbles
Copy link
Member

rtibbles commented Nov 1, 2023

Fixed in #11366

@rtibbles rtibbles closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thesujai thesujai

Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Milestone
Kolibri 0.17: General maintenance, bu...
Development

No branches or pull requests
4 participants
@rtibbles @MisRob @marcellamaki @thesujai