Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.16 into develop #11460

Merged
merged 221 commits into from
Oct 25, 2023
Merged

Conversation

rtibbles
Copy link
Member

Summary

Cascade merge

Merge conflicts:

#	kolibri/core/auth/serializers.py
#	kolibri/core/package.json
#	kolibri/plugins/coach/assets/src/views/CoachImmersivePage.vue
#	kolibri/plugins/perseus_viewer/assets/src/views/PerseusRendererIndex.vue
#	yarn.lock

Nothing particularly tricky about the merge conflict resolutions.

  • serializers.py was just two adjacent import changes resolved
  • package.json resolved in favour of the KDS beta - as the commit referenced by develop appears to be unfindable
  • CoachImmersivePage - complete vs partial removal of unused class
  • PerseusRendererIndex - two adjacent import edits
  • yarn.lock automatically resolved by yarn

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

rtibbles and others added 30 commits August 8, 2023 10:25
Include diskcache directory in file size counts.
Bumps [launch-editor-middleware](https://github.com/yyx990803/launch-editor) from 2.6.0 to 2.6.1.
- [Commits](yyx990803/launch-editor@v2.6.0...v2.6.1)

---
updated-dependencies:
- dependency-name: launch-editor-middleware
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Commit updates to state sorted by timestamp.
Fixes learningequality#11302
where "Completed" update was commited before "Started" update.
… Media Player plugin (learningequality#11365)

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Media Player plugin
…dabot/npm_and_yarn/launch-editor-middleware-2.6.1

Bump launch-editor-middleware from 2.6.0 to 2.6.1
Bumps [csv-parse](https://github.com/adaltas/node-csv/tree/HEAD/packages/csv-parse) from 5.5.1 to 5.5.2.
- [Changelog](https://github.com/adaltas/node-csv/blob/master/packages/csv-parse/CHANGELOG.md)
- [Commits](https://github.com/adaltas/node-csv/commits/[email protected]/packages/csv-parse)

---
updated-dependencies:
- dependency-name: csv-parse
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…ns-order

Fix order in which notification updates are commited to state
…ools

Update package versions for latest publish.
…dabot/npm_and_yarn/csv-parse-5.5.2

Bump csv-parse from 5.5.1 to 5.5.2
…le download button after download initiated cleanup
… polls for the currently available devices and can be shared across components and files
dependabot bot and others added 17 commits October 24, 2023 00:34
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…dabot/npm_and_yarn/eslint-plugin-import-2.29.0

Bump eslint-plugin-import from 2.28.1 to 2.29.0
…dabot/github_actions/actions/setup-node-4

Bump actions/setup-node from 3 to 4
…dal_Message

Fix unwanted welcomeModal display
…storage-not-calculated

Fixes My downloads - The 'Available storage' value not being calculated when I am signed in as a Learner
Bumps [xstate](https://github.com/statelyai/xstate) from 4.38.2 to 4.38.3.
- [Release notes](https://github.com/statelyai/xstate/releases)
- [Commits](https://github.com/statelyai/xstate/compare/[email protected]@4.38.3)

---
updated-dependencies:
- dependency-name: xstate
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…dabot/npm_and_yarn/xstate-4.38.3

Bump xstate from 4.38.2 to 4.38.3
# Conflicts:
#	kolibri/core/auth/serializers.py
#	kolibri/core/package.json
#	kolibri/plugins/coach/assets/src/views/CoachImmersivePage.vue
#	kolibri/plugins/perseus_viewer/assets/src/views/PerseusRendererIndex.vue
#	yarn.lock
@rtibbles rtibbles added the TODO: needs review Waiting for review label Oct 25, 2023
@rtibbles rtibbles requested a review from marcellamaki October 25, 2023 21:38
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) SIZE: medium labels Oct 25, 2023
@marcellamaki marcellamaki merged commit 545323a into learningequality:develop Oct 25, 2023
34 checks passed
@rtibbles rtibbles deleted the 0.16intodevelop branch October 26, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment SIZE: medium TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.