-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace KResponseWindow with useKResponseWindow in Device plugin #11349
Replace KResponseWindow with useKResponseWindow in Device plugin #11349
Conversation
@MisRob please have a look |
Build Artifacts
|
kolibri/plugins/device/assets/src/views/ManageTasksPage/TaskPanel.vue
Outdated
Show resolved
Hide resolved
@thesujai Thanks! I will review code in more detail later on, but briefly skimmed through it and looks great. Can you recall which pages are affected? For our QA team, it'd be helpful to have a list of pages from the user-point of view, for example their URLs |
^ This would also helps us in your other PRs |
Here's a nice example #11346 (comment) |
Yes sure |
@MisRob For few changes which I did, I was not able to visually find the page in which it is reflected due to my less familiarity with the codeabse. Like file |
Thank you @thesujai, it's okay especially when you mentioned the places that you couldn't locate. I will try it out. |
@thesujai Could you please rebase on top of the latest develop? That should hopefully resolve failing test check. |
Hey @MisRob, can say a suitable method for rebasing it, last time i tried in another pr and it got messed up |
Okay @MisRob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @thesujai.
Code is fine, I tested all the places and haven't observed any regressions or console errors.
Let's hold merging though for some time. As soon as tests are fixed on |
Summary
I searched for all .vue in
kolibri/plugins/device
, and i started to replaceKResponsiveWindow
withuseKResponsiveWindow
For testing:
windowBreakpoint
is reached.KResponsiveWindow
anduserKResponsiveWindow
Page Affected
…
References
Fixes #11322
Reviewer guidance
Would it be possible to add a
hacktoberfest-accepted
label in this PR?Here is the link: https://hacktoberfest.com/participation/#maintainers
Its fine if for some reasons you aren't able to do so:)
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)