-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature quiz section tabs with overflow #11382
Feature quiz section tabs with overflow #11382
Conversation
Build Artifacts
|
…n closing side panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very exciting feature, it already looks amazing! A couple of things I noticed was that the KLinearLoader
remains on the page even after the quiz creation section has finished loading. I saw that the CoachImmersivePage
accepts a loading prop that might need to be provided.
Also, when you exit out of creating a quiz without saving, and then select "new quiz" again, although the array of tabs appears to be the correct length, the section counter continues as if you never exited out of creating the quiz. It does correctly reset on page reload.
Summary
<slots>
Inception so hopefully it isn't too squirrelyHorizontalMenuWithOverflow
component where we useoverflow: hidden
andflex-wrap
to allow the tabs to render out of sight. We calculate "which tabs are out of sight?" then present those items in the dropdown menu. The accessible solution here seemed to be to puttabindex=-1
onto the overflow dropdown such that it will not be focused. Instead, the focus just continues onto the hidden tabs, showing them visibly.messageLabel$
convention for strings.NOTE: This uses this KDS PR
References
Closes #11274
Reviewer guidance
Apologies for lack of videos - I am having issues recording things right now.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)