Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced responsiveWindow with useKResponsiveWindow #11355

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

ShivangRawat30
Copy link
Contributor

Summary

This PR replaces responsiveWindowMixin with useKResponsiveWindow

References

This PR Resolves #11325

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: very small labels Oct 5, 2023
@rtibbles
Copy link
Member

rtibbles commented Oct 9, 2023

This needs to be rebased onto latest develop to resolve the conflict!

@MisRob MisRob self-requested a review October 10, 2023 07:52
@github-actions github-actions bot added APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) SIZE: medium labels Oct 11, 2023
@github-actions github-actions bot removed the APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) label Oct 12, 2023
@rtibbles
Copy link
Member

The rebase wasn't quite right here - have rectified it.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ShivangRawat30. Code looks to be okay to me. I tested all affected pages and observed no issues.

The tests are failing due to TypeError: window.matchMedia is not a function. We already have a fix for it. After it's available in Kolibri, I will rebase this PR on top of the latest develop and merge it.

@MisRob MisRob merged commit 60ca630 into learningequality:develop Oct 26, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: medium SIZE: small SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants