-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced responsiveWindow with useKResponsiveWindow #11355
Conversation
Build Artifacts
|
This needs to be rebased onto latest develop to resolve the conflict! |
Signed-off-by: shivangrawat30 <[email protected]>
Signed-off-by: shivangrawat30 <[email protected]>
The rebase wasn't quite right here - have rectified it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ShivangRawat30. Code looks to be okay to me. I tested all affected pages and observed no issues.
The tests are failing due to TypeError: window.matchMedia is not a function
. We already have a fix for it. After it's available in Kolibri, I will rebase this PR on top of the latest develop and merge it.
Summary
This PR replaces
responsiveWindowMixin
withuseKResponsiveWindow
References
This PR Resolves #11325
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)