Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced KResponsiveWindow mixin by useKResponsiveWindow composable - Core #11335 #11427

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

a6ar55
Copy link
Contributor

@a6ar55 a6ar55 commented Oct 18, 2023

Summary

Replaced all KResponsiveWindow with useKResponsWindow in kolibri/core .vue files

References

This addresses issue #11335.

Reviewer guidance

is it possible to add hacktoberfest-accepted label in this PR ?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob self-requested a review October 19, 2023 10:13
@MisRob MisRob added TODO: needs review Waiting for review hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest labels Oct 19, 2023
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) labels Oct 26, 2023
@MisRob MisRob changed the base branch from release-v0.16.x to develop October 26, 2023 07:04
@MisRob
Copy link
Member

MisRob commented Oct 26, 2023

@a6ar55 I rebased this to develop branch

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @a6ar55, thank you for the contribution!

Code looks good to me. I also previewed updated places and observed no regressions.

@MisRob MisRob merged commit db111b3 into learningequality:develop Oct 26, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: backend Python, databases, networking, filesystem... hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants