Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Core #11335

Closed
Tracked by #11321
MisRob opened this issue Sep 29, 2023 · 11 comments
Closed
Tracked by #11321

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Core #11335

MisRob opened this issue Sep 29, 2023 · 11 comments
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Sep 29, 2023

This is one of the issues whose common goal is to gradually replace KResponsiveWindow mixin by useKResponsiveWindow composable.

First, see #11321 for detailed instructions and acceptance criteria common to all issues.

Then, replace KResponsiveWindow mixin by useKResponsiveWindow composable in all .vue files of the Core (/kolibri/core)

@MisRob MisRob added P2 - normal Priority: Nice to have DEV: frontend help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Sep 29, 2023
@ShivangRawat30
Copy link
Contributor

I would like to work on it.

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

@ShivangRawat30 I already assigned you some other issues so I'll leave this open for other contributors. You're welcome to remind yourself here again as soon as you've finished them (explained more in one of the comments I left for you).

@a6ar55
Copy link
Contributor

a6ar55 commented Oct 3, 2023

hey @MisRob ,I would like to work on it.

@MisRob
Copy link
Member Author

MisRob commented Oct 4, 2023

Hi @a6ar55, thanks for volunteering. You're welcome to tackle it. Please see the contributing guidelines if you haven't seen them yet. I'd also recommend studying changes and review of this pull request which resolves the same thing in a different plugin and already have some notes from reviewers so you can use it as a guidance.

@a6ar55
Copy link
Contributor

a6ar55 commented Oct 4, 2023

Okey, sure I will look into it 👍

@Suraj-kumar00
Copy link
Contributor

Hi @MisRob, I saw here no one is working and i really want to contribute to this issue , can you please assign this issue to me please!

@MisRob
Copy link
Member Author

MisRob commented Oct 5, 2023

Hi @Suraj-kumar00, thanks! This is already taken by @a6ar55, I only forgot to make the assignment. I just assigned you the other issue from the group you asked for though.

@Suraj-kumar00
Copy link
Contributor

Member

yeah thanks !

@a6ar55
Copy link
Contributor

a6ar55 commented Oct 18, 2023

Hi @MisRob, I've submitted a pull request. I carefully reviewed the documentation and implemented the required changes. This was my first experience working with composables in Vue. Could you please take a look and provide feedback?

@MisRob
Copy link
Member Author

MisRob commented Oct 19, 2023

Hi @a6ar55, thank you! Overall it's looking good to me. I will review in detail in the upcoming days.

MisRob added a commit that referenced this issue Oct 26, 2023
Replaced KResponsiveWindow mixin by useKResponsiveWindow composable - Core #11335
@MisRob
Copy link
Member Author

MisRob commented Oct 26, 2023

Closed by #11427

@MisRob MisRob closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

4 participants