-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Core #11335
Comments
I would like to work on it. |
@ShivangRawat30 I already assigned you some other issues so I'll leave this open for other contributors. You're welcome to remind yourself here again as soon as you've finished them (explained more in one of the comments I left for you). |
hey @MisRob ,I would like to work on it. |
Hi @a6ar55, thanks for volunteering. You're welcome to tackle it. Please see the contributing guidelines if you haven't seen them yet. I'd also recommend studying changes and review of this pull request which resolves the same thing in a different plugin and already have some notes from reviewers so you can use it as a guidance. |
Okey, sure I will look into it 👍 |
Hi @MisRob, I saw here no one is working and i really want to contribute to this issue , can you please assign this issue to me please! |
Hi @Suraj-kumar00, thanks! This is already taken by @a6ar55, I only forgot to make the assignment. I just assigned you the other issue from the group you asked for though. |
yeah thanks ! |
Hi @MisRob, I've submitted a pull request. I carefully reviewed the documentation and implemented the required changes. This was my first experience working with composables in Vue. Could you please take a look and provide feedback? |
Hi @a6ar55, thank you! Overall it's looking good to me. I will review in detail in the upcoming days. |
Replaced KResponsiveWindow mixin by useKResponsiveWindow composable - Core #11335
Closed by #11427 |
This is one of the issues whose common goal is to gradually replace
KResponsiveWindow
mixin byuseKResponsiveWindow
composable.First, see #11321 for detailed instructions and acceptance criteria common to all issues.
Then, replace
KResponsiveWindow
mixin byuseKResponsiveWindow
composable in all .vue files of the Core (/kolibri/core)The text was updated successfully, but these errors were encountered: