Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ namespaces, directories and header guards from ignition to gz #711

Closed
Tracked by #698
methylDragon opened this issue Apr 21, 2022 · 2 comments
Closed
Tracked by #698
Labels
ign to gz Renaming Ignition to Gazebo.

Comments

@methylDragon
Copy link
Contributor

methylDragon commented Apr 21, 2022

Description

This issue tracks the conversion of C++ namespaces from ignition to gz.

Example PRs:

Be sure to use this trick:

namespace [[deprecated]] ignition {
  using namespace gz;
}

Status Tracker

(Some of these might be excluded, but I'm just listing the full list first!)

Header Migration

There's a script to automate the process for the most part, but some manual work has to be done: #712
See the script PR for the caveats and a point in the right direction for what manual work has to be done (and why!)

It helps to do this in topological order!

Namespacing Narrowed

Partial Macros and Docs

Pre-req


Future Work

After the namespaces are migrated, we need to do the source and macro migration (from upstream to downstream.)

@methylDragon
Copy link
Contributor Author

We... are going to need to merge these in topological order again :(

@chapulina chapulina changed the title C++ namespaces from ignition to gz C++ namespaces, directories and header guards from ignition to gz May 3, 2022
@chapulina
Copy link
Contributor

All namespaces merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Development

No branches or pull requests

2 participants