Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Migrate Examples : gz-gui #406

Merged
merged 1 commit into from
May 27, 2022
Merged

ign -> gz Migrate Examples : gz-gui #406

merged 1 commit into from
May 27, 2022

Conversation

methylDragon
Copy link
Contributor

Signed-off-by: methylDragon <[email protected]>
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #406 (bc90810) into main (01a0753) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   30.03%   30.03%           
=======================================
  Files          43       43           
  Lines        1888     1888           
=======================================
  Hits          567      567           
  Misses       1321     1321           
Impacted Files Coverage Δ
include/gz/gui/qrc_resources.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b65b81...bc90810. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moved files LGTM, but we have to revert the gzdbg changes

src/Application.cc Outdated Show resolved Hide resolved
@chapulina chapulina merged commit 2c5d186 into main May 27, 2022
@chapulina chapulina deleted the move_examples branch May 27, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants