Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-transport #311

Merged
merged 28 commits into from
May 29, 2022
Merged

ign -> gz Namespace Migration : gz-transport #311

merged 28 commits into from
May 29, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon
Update header guards
b7723c3 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate namespaces
481885c 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add migration line
2abe365 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Implement deprecation trick
9796364 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add deprecation test
12e202b 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Include config.hh
a8e9431 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon mentioned this pull request May 18, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 18, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 18, 2022
chapulina
chapulina reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the 2 comments

Migration.md Show resolved Hide resolved
include/ignition/transport/config.hh Outdated Show resolved Hide resolved
@methylDragon
Use pragma deprecation message instead
2ee6c0c 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Ticktock config macros
c315bb8 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix migration
1546644 
Signed-off-by: methylDragon <[email protected]>
chapulina
chapulina approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

include/gz/transport/config.hh.in Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch 5 times, most recently from 40ad9f6 to 68bc092 Compare May 20, 2022 08:59
chapulina
chapulina suggested changes May 25, 2022
View reviewed changes
log/src/Log_TEST.cc Show resolved Hide resolved
tutorials/20_env_variables.md Show resolved Hide resolved
tutorials/21_contribute.md Outdated Show resolved Hide resolved
chapulina
chapulina approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI!

@chapulina chapulina mentioned this pull request May 29, 2022
Merged
@methylDragon
Fix linting errors
f4deacb 
Signed-off-by: methylDragon <[email protected]>
@codecov
Copy link

codecov bot commented May 29, 2022 •
edited
Loading

Codecov Report

Merging #311 (f4deacb) into main (703f52c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines          24       24           
=======================================
  Hits           16       16           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703f52c...f4deacb. Read the comment docs.

@methylDragon methylDragon merged commit 83ada1b into main May 29, 2022
@methylDragon methylDragon deleted the namespace_migration branch May 29, 2022 01:06
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina