Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Header Migration : ign-math (2) #419

Merged
merged 3 commits into from
May 4, 2022

Conversation

methylDragon
Copy link
Contributor

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #419 (8b39da5) into main (9b7714c) will not change coverage.
The diff coverage is n/a.

❗ Current head 8b39da5 differs from pull request most recent head dab3134. Consider uploading reports for the commit dab3134 to get more accurate results

@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          49       49           
  Lines        4396     4396           
=======================================
  Hits         4389     4389           
  Misses          7        7           
Impacted Files Coverage Δ
...e/ignition/math7/ignition/math/detail/AxisIndex.hh
...n/math7/ignition/math/VolumetricGridLookupField.hh
...n/math7/ignition/math/detail/InterpolationPoint.hh
...gnition/math7/gz/math/VolumetricGridLookupField.hh 94.82% <0.00%> (ø)
...gnition/math7/gz/math/detail/InterpolationPoint.hh 100.00% <0.00%> (ø)
...include/ignition/math7/gz/math/detail/AxisIndex.hh 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7714c...dab3134. Read the comment docs.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix; looks good, and you can optionally amend the last commit with (#419) in the commit message

@methylDragon methylDragon merged commit e4a06a7 into main May 4, 2022
@methylDragon methylDragon deleted the header_migration_followup branch May 4, 2022 18:19
methylDragon added a commit that referenced this pull request May 4, 2022
methylDragon added a commit that referenced this pull request May 4, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants