Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining #include statements to use gz/ #427

Merged
merged 10 commits into from
May 10, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented May 9, 2022

🦟 Bug fix

Part of gazebo-tooling/release-tools#711, follow-up to #413 and #419.

Summary

The ignition headers have been migrated to include/gz/, and this converts the remaining #include <ignition/*> statements to #include <gz/*>. I split the changes into multiple commits to break it up a bit since there are many changes.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from methylDragon May 9, 2022 22:42
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #427 (9a6c325) into main (2f75151) will not change coverage.
The diff coverage is n/a.

❗ Current head 9a6c325 differs from pull request most recent head 3ffff69. Consider uploading reports for the commit 3ffff69 to get more accurate results

@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          49       49           
  Lines        4396     4396           
=======================================
  Hits         4389     4389           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f75151...3ffff69. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 10, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scpeters !

@chapulina chapulina merged commit 84e650a into gazebosim:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants