Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-fuel-tools #251

Merged
merged 25 commits into from
May 29, 2022
Merged

ign -> gz Namespace Migration : gz-fuel-tools #251

merged 25 commits into from
May 29, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request May 18, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 18, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 18, 2022
chapulina
chapulina approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

Migration.md Outdated Show resolved Hide resolved
include/gz/fuel_tools/config.hh.in Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch 4 times, most recently from 3a8c645 to 9450d98 Compare May 20, 2022 08:59
chapulina
chapulina suggested changes May 25, 2022
View reviewed changes
src/WorldIter_TEST.cc Outdated Show resolved Hide resolved
@methylDragon
Update header guards
c357c82 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate namespaces
fdff44d 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add migration line
2bbde9b 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Implement deprecation trick
24153be 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add deprecation test
f1617d4 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Include config.hh
32ea67c 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Use pragma deprecation message instead
09863fa 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Ticktock config macros
7ba6c40 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate includes to gz
2b9e799 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Mention gz headers in migration
5e294ac 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Update config.hh
bdd6706 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate Export.hh macros and deprecated test
39dd741 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate more macros and test_config.h
7886d7b 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate github links
4ffd59e 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate user-facing Ignition to Gazebo
aff111e 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate gz-common logging calls
b35d6d3 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Include config.hh in recursive directories and <lib>.hh
3a55ad2 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Gazebo Robotics -> Gazebo
83df185 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
ignitionrobotics -> gazebosim
5e6ba10 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Revert migration for fuel.ignitionrobotics.org
f165602 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Rollback osrf-migration.github.io migrations
acc1d37 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Revert URL changes in code
c540e70 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Wording changes
f3d46db 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate igndbg -> gzdbg
989bbe0 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Post-rebase gzerr, gzdbg, Gazebo Fuel Tools migration
214227d 
Signed-off-by: methylDragon <[email protected]>
chapulina
chapulina approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

@chapulina chapulina mentioned this pull request May 29, 2022
Merged
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
@chapulina chapulina merged commit 056cd81 into main May 29, 2022
@chapulina chapulina deleted the namespace_migration branch May 29, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina