ign -> gz File Move for IgnHlms #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
migrate_ignhlms
branch
from
ec31847
to
1a72c69
Compare
chapulina
approved these changes
May 23, 2022
| @@ -54,7 +54,7 @@ namespace ignition | |||
| // | |||
| // forward declaration | |||
| class Ogre2RenderEnginePrivate; | |||
| class Ogre2IgnHlmsSphericalClipMinDistance; | |||
| class Ogre2GzHlmsSphericalClipMinDistance; | |||
There was a problem hiding this comment.
Not this PR's fault, but I wonder how downstream applications are expected to use the Ogre2RenderEngine.hh header if the Ogre2IgnHlmsSphericalClipMinDistance header isn't installed.
Codecov Report
@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 1 1
Lines 15 15
=======================================
Hits 12 12
Misses 3 3 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: gazebo-tooling/release-tools#711