Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration (2) : gz-cmake #260

Merged
merged 8 commits into from
May 24, 2022
Merged

ign -> gz Namespace Migration (2) : gz-cmake #260

merged 8 commits into from
May 24, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon
Migrate Export.hh macros
5dc6538 
Signed-off-by: methylDragon <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 20, 2022
@methylDragon methylDragon mentioned this pull request May 20, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 23, 2022
methylDragon and others added 3 commits May 23, 2022 16:21
@methylDragon
Gazebo Robotics -> Gazebo
20e9e0d 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
ignitionrobotics -> gazebosim
b626910 
Signed-off-by: methylDragon <[email protected]>
@chapulina
merged from main
f13f3c0 
Signed-off-by: Louise Poubel <[email protected]>
chapulina
chapulina approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We technically don't need to change the macros in include/ignition because they're all deprecated, but it doesn't hurt anything and reduces the clutter when grepping for ign, so I think it's ok to leave them in.

LGTM once the BitBucket entries on the changelog are reverted.

Changelog.md Outdated Show resolved Hide resolved
@chapulina chapulina enabled auto-merge (squash) May 24, 2022 00:16
@chapulina chapulina merged commit 0b91106 into main May 24, 2022
@chapulina chapulina deleted the namespace_migration branch May 24, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina